Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.12] ODH preparation for v0.12.1 #339

Conversation

israel-hdez
Copy link

What this PR does / why we need it:

Code sync with upstream release v0.12.1.

sivanantha321 and others added 7 commits April 17, 2024 00:59
…#3609)

* CVE-2024-24762 - update fastapi to 0.109.1

chore:	Fix [CVE-2024-24762](https://www.cve.org/CVERecord?id=CVE-2024-24762) - fastapi Regular Expression Denial of Service (ReDoS)
	Plus, update Ray to 2.10 to allow updating fastapi. On previous versions of Ray
	the fastapi version was pinned, which was preventing the fastapi version update.

use the new handle api:

From Ray Serve docs:
Ray 2.7 introduces a new {mod}`DeploymentHandle <ray.serve.handle.DeploymentHandle>` API that will replace the existing `RayServeHandle` and `RayServeSyncHandle` APIs.

Signed-off-by: Spolti <fspolti@redhat.com>
Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* add link to about the RayServeHandle deprecation

Signed-off-by: Spolti <fspolti@redhat.com>
Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* restrict pydantic version <1,>2

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

---------

Signed-off-by: Spolti <fspolti@redhat.com>
Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Co-authored-by: Spolti <fspolti@redhat.com>
* feat: upgrade to new fastapi, update models to handle both pydantic v… (kserve#3374)

* feat: add support for pydantic v2, tests for pydantic v1, and update dependencies

Signed-off-by: Timothy Laurent <tlaurent@genedx.com>

* feat: regenerate lock files

Signed-off-by: Timothy Laurent <tlaurent@genedx.com>

* feat: regenerate lock files with updates

Signed-off-by: Timothy Laurent <tlaurent@genedx.com>

* fix: update dependencies, fix broken tests

* feat: add special case for testing model ready, "True" for pydantic v1

* Update poetry lock

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

---------

Signed-off-by: Timothy Laurent <tlaurent@genedx.com>
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Co-authored-by: Dan Sun <dsun20@bloomberg.net>
Signed-off-by: Curtis Maddalozzo <cmaddalozzo@bloomberg.net>

* Remove python 3.8

---------

Signed-off-by: Timothy Laurent <tlaurent@genedx.com>
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Signed-off-by: Curtis Maddalozzo <cmaddalozzo@bloomberg.net>
Co-authored-by: Timothy J Laurent <timothyjlaurent@gmail.com>
Co-authored-by: Dan Sun <dsun20@bloomberg.net>
Make the modelcar injection idempotent

Due to changes in kserve@39b8a67 which added `reinvocationPolicy: IfNeeded` to the WebHook configuration, the injection called can (and will be) called multiple times, and needs to be idempotent (which is a good thing anyway).

This commit fixes the array field handling and adding volumes, volumemounts and containers only if they not already had been added.

Fixes kserve#3506

Signed-off-by: Roland Huß <rhuss@redhat.com>
Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Co-authored-by: Roland Huß <rhuss@redhat.com>
Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
* pin back ray to 2.10

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Update sklearn lockfile

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

---------

Signed-off-by: Dan Sun <dsun20@bloomberg.net>
fix docker build failure

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
This prepares ODH to deliver an equivalent to upstream version 0.12.1.

Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>
Copy link

openshift-ci bot commented May 3, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented May 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: israel-hdez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label May 3, 2024
@israel-hdez israel-hdez changed the base branch from release-v0.12.0 to release-v0.12.1 May 3, 2024 19:24
@israel-hdez israel-hdez marked this pull request as ready for review May 3, 2024 19:25
@Jooho
Copy link

Jooho commented May 4, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 4, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit c6fb96d into opendatahub-io:release-v0.12.1 May 4, 2024
18 checks passed
@israel-hdez israel-hdez deleted the odh-release-v0.12.1-sync branch May 6, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants