Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Workflow for release and tag with Changelog #287

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

rpancham
Copy link

@rpancham rpancham commented Apr 4, 2024

What this PR does / why we need it:
Automate ODH Release Process for Kserve repos

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #RHOAIENG-2732

Copy link

openshift-ci bot commented Apr 4, 2024

Hi @rpancham. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@heyselbi
Copy link

heyselbi commented Apr 8, 2024

/ok-to-test

.github/workflows/create-release-tag.yml Outdated Show resolved Hide resolved
.github/workflows/create-release-tag.yml Outdated Show resolved Hide resolved
Copy link

openshift-ci bot commented Apr 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rpancham

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

@israel-hdez israel-hdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpancham do you want to promote this out of draft?
I think this is good enough to be merged.

The only subtle additional feedback I have, but that I think it is quite important, is to add the odh- prefix to the new file. This is to have a clear distinction between upstream workflows and the ones we created in ODH.

.github/workflows/create-release-tag.yml Show resolved Hide resolved
@heyselbi
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 16, 2024
@heyselbi heyselbi marked this pull request as ready for review April 16, 2024 05:14
@openshift-ci openshift-ci bot requested review from Jooho and spolti April 16, 2024 05:14
@rpancham
Copy link
Author

/test e2e-raw

@rpancham
Copy link
Author

/test e2e-slow

@rpancham
Copy link
Author

/retest

@rpancham
Copy link
Author

/retest-required

@rpancham
Copy link
Author

/test e2e-slow

@openshift-ci openshift-ci bot removed the lgtm label Apr 19, 2024
@vaibhavjainwiz
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 19, 2024
@vaibhavjainwiz vaibhavjainwiz merged commit 9a43dfa into opendatahub-io:master Apr 19, 2024
27 of 29 checks passed
israel-hdez pushed a commit to israel-hdez/kserve that referenced this pull request May 3, 2024
israel-hdez pushed a commit to israel-hdez/kserve that referenced this pull request May 4, 2024
israel-hdez pushed a commit to israel-hdez/kserve that referenced this pull request May 4, 2024
israel-hdez pushed a commit to israel-hdez/kserve that referenced this pull request May 6, 2024
@rpancham rpancham deleted the release_tag_wf branch July 10, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants