Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt GH-workflows to correctly push to ODH container repositories #28

Merged

Conversation

israel-hdez
Copy link

  • Workflows are changed to push to Quay.io.
  • The go.yml workflow is changed to omit updating the coverage badge (we don't have one, for now).
  • The README.md file is updated to right ODH urls.

Which issue(s) this PR fixes

Fixes #27

Type of changes
Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Release note:

NONE

* Workflows are changed to push to Quay.io.
* The go.yml workflow is changed to omit updating the coverage badge (we don't have one, for now).
* The README.md file is updated to right ODH urls.

Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>
Copy link

@Jooho Jooho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

@danielezonca danielezonca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@israel-hdez israel-hdez merged commit 48ac5cb into opendatahub-io:master Jul 14, 2023
18 checks passed
@israel-hdez israel-hdez deleted the fix-actions-image-push branch July 14, 2023 17:20
@israel-hdez israel-hdez self-assigned this Jul 14, 2023
@israel-hdez israel-hdez added the kind/bug Something isn't working label Jul 14, 2023
Jooho pushed a commit to Jooho/kserve that referenced this pull request Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Fix image pushing with GitHub actions
3 participants