-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare ODH's v0.12.0 branch cut #262
Prepare ODH's v0.12.0 branch cut #262
Conversation
) * Add model_version to InferResponse class Signed-off-by: Adam Stewart <adam.stewart73@gmail.com> * Update infer_type tests Signed-off-by: Adam Stewart <adam.stewart73@gmail.com> * Updated from_grpc class method argument ordering Signed-off-by: Adam Stewart <adam.stewart73@gmail.com> --------- Signed-off-by: Adam Stewart <adam.stewart73@gmail.com>
For that a new injector that adds a so-called "modelcar" container to "kserve-container" as a sidecar has been added. This setups a pod for sharing the process namespace (shareProcessNamespace = true). The following configuration options have been added: * `enableModelcar` to switch on this feature (default: false) * `cpuModelcar` and `memoryModelcar` to set the resources for the modelcar container * `uidModelcar` for the UID to use for the user-container *and* the modelcar contained See kserve#3110 for more information and architecture of this feature. Signed-off-by: Roland Huß <rhuss@redhat.com>
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
/retest |
/hold |
8518452
to
53e865a
Compare
/unhold |
…0.12 Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>
53e865a
to
4cdd3a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: israel-hdez, Jooho The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
535288f
into
opendatahub-io:release-v0.12.0
…tudio-kserve-router-nightly Red Hat Konflux update kserve-router-nightly
What this PR does / why we need it:
This brings the pending commits from upstream
v0.12.0
tag to ODHrelease-v0.12.0
branch.The ODH
release-v0.12.0
branch was cut to the closest commit to upstreamv0.12.0
tag. This brings the additional commits present in upstreamv0.12.0
tag to ODHrelease-v0.12.0
branch to make the branch equivalent to upstream v0.12.0 release.Which issue(s) this PR fixes
Related to https://issues.redhat.com/browse/RHOAIENG-4180