Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare ODH's v0.12.0 branch cut #262

Conversation

israel-hdez
Copy link

@israel-hdez israel-hdez commented Mar 4, 2024

What this PR does / why we need it:

This brings the pending commits from upstream v0.12.0 tag to ODH release-v0.12.0 branch.

The ODH release-v0.12.0 branch was cut to the closest commit to upstream v0.12.0 tag. This brings the additional commits present in upstream v0.12.0 tag to ODH release-v0.12.0 branch to make the branch equivalent to upstream v0.12.0 release.

Which issue(s) this PR fixes
Related to https://issues.redhat.com/browse/RHOAIENG-4180

ajstewart and others added 3 commits February 24, 2024 14:18
)

* Add model_version to InferResponse class

Signed-off-by: Adam Stewart <adam.stewart73@gmail.com>

* Update infer_type tests

Signed-off-by: Adam Stewart <adam.stewart73@gmail.com>

* Updated from_grpc class method argument ordering

Signed-off-by: Adam Stewart <adam.stewart73@gmail.com>

---------

Signed-off-by: Adam Stewart <adam.stewart73@gmail.com>
For that a new injector that adds a so-called "modelcar"
container to "kserve-container" as a sidecar has been added.
This setups a pod for sharing the process namespace
(shareProcessNamespace = true).

The following configuration options have been added:

* `enableModelcar` to switch on this feature (default: false)
* `cpuModelcar` and `memoryModelcar` to set the resources for the
   modelcar container
* `uidModelcar` for the UID to use for the user-container *and*
   the modelcar contained

See kserve#3110 for more information and
architecture of this feature.

Signed-off-by: Roland Huß <rhuss@redhat.com>
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
@israel-hdez
Copy link
Author

/retest

@israel-hdez
Copy link
Author

/hold

@israel-hdez
Copy link
Author

/unhold

…0.12

Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>
Copy link

@Jooho Jooho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Apr 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: israel-hdez, Jooho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 535288f into opendatahub-io:release-v0.12.0 Apr 10, 2024
22 of 23 checks passed
@israel-hdez israel-hdez deleted the odh-prepare-v0.12 branch April 10, 2024 22:55
Jooho pushed a commit to Jooho/kserve that referenced this pull request May 7, 2024
…tudio-kserve-router-nightly

Red Hat Konflux update kserve-router-nightly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants