Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.11.1] Increase memory limit of kserve-controller pod #259

Conversation

israel-hdez
Copy link

What this PR does / why we need it:

The increased memory limit is for the controller pod to work normally in clusters having 9k+ secrets.

Which issue(s) this PR fixes

Fixes https://issues.redhat.com/browse/RHOAIENG-3996

Type of changes
Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Feature/Issue validation/testing:

With KServe deployed:

The increased memory limit is for the controller pod to work normally in clusters having 9k+ secrets.

Fixes https://issues.redhat.com/browse/RHOAIENG-3996

Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>
Copy link

openshift-ci bot commented Mar 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: israel-hdez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Mar 1, 2024
@taneem-ibrahim taneem-ibrahim requested review from terrytangyuan and removed request for davidesalerno March 1, 2024 18:52
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make this change to master branch first and then cherry-pick to the release branch?

@israel-hdez
Copy link
Author

israel-hdez commented Mar 1, 2024

Should we make this change to master branch first and then cherry-pick to the release branch?

We could, although I'm not sure if it would be short-lived if the upstream fix is merged soon.
The master branch would get the long-term fix is if the upstream PR is approved.

If you prefer the fix to be in master too, I could cherry-pick this to master (commits are going to be different, anyway).

@terrytangyuan
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 1, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit ed76729 into opendatahub-io:release-v0.11.1 Mar 1, 2024
20 checks passed
@israel-hdez israel-hdez deleted the jira-3396-workaround branch March 1, 2024 21:05
Jooho pushed a commit to Jooho/kserve that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants