Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cherry pick] fixes to current release branch 0.11.1 #230

Merged
merged 4 commits into from
Feb 22, 2024

Conversation

israel-hdez
Copy link

What this PR does / why we need it:

Cherry pick:

Copy link

openshift-ci bot commented Feb 22, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

dtrifiro and others added 3 commits February 21, 2024 18:36
…re set in storage secret json (kserve#3259)

By setting environment variables to the result of `.get(..., "")`,
the corresponding env variables are set to an empty value.

This is an issue for some values, such as `AWS_CA_BUNDLE`, which should
be set to a path pointing to a valid CA bundle. When set to an empty string,
 it is propagated all the way down to `botocore.httpsession.URLLib3Session._setup_ssl_cert`,
 which interprets it as `False` and disables verification.

See https://github.com/boto/botocore/blob/6e0ec833714ed88d46e294048cdb0d3869eb2ab5/botocore/httpsession.py#L376-L382

Signed-off-by: Daniele Trifirò <dtrifiro@redhat.com>
…ve#3436)

* feat: Allow to disable ingress creation for raw deployment mode

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* test

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* Add configs

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* codegen

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* python docs

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* update helm docs

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* undo changes in pkg/apis/serving/v1beta1/zz_generated.deepcopy.go

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* remove unnecessary changes

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* Empty-Commit

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* remove hf change

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* Update config/configmap

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* fix chart syntax

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* Empty-Commit

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

---------

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jooho Do you want to include kserve#3463?

@Jooho
Copy link

Jooho commented Feb 22, 2024

@terrytangyuan yes!

@spolti
Copy link
Member

spolti commented Feb 22, 2024

The raw deployment is not 100% working, right?
Do we want to cherry-pick it?

@terrytangyuan
Copy link
Member

The raw deployment is not 100% working, right?

What is not working?

@spolti
Copy link
Member

spolti commented Feb 22, 2024

The raw deployment is not 100% working, right?

What is not working?

That combination that Daniele mentioned on yesterday's meeting.
We might need to wait for the fix, no?

@israel-hdez
Copy link
Author

@Jooho Do you want to include kserve#3463?

@terrytangyuan I think that @Jooho already picked that one here: #221.

Because the config variable was renamed from `certificate` to `ca_bundle`.

Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Feb 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: israel-hdez, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [israel-hdez,terrytangyuan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jooho Jooho changed the title Cherry pick fixes to current release branch 0.11.1 [Cherry pick] fixes to current release branch 0.11.1 Feb 22, 2024
@Jooho Jooho merged commit 0b7d2bc into opendatahub-io:release-v0.11.1 Feb 22, 2024
18 of 20 checks passed
@israel-hdez israel-hdez deleted the v0.11.1-2.8-picks branch February 22, 2024 17:00
spolti referenced this pull request in spolti/kserve Apr 17, 2024
…gent-29

Red Hat Konflux update kserve-agent-29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants