-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cherry pick] fixes to current release branch 0.11.1 #230
[Cherry pick] fixes to current release branch 0.11.1 #230
Conversation
Skipping CI for Draft Pull Request. |
…re set in storage secret json (kserve#3259) By setting environment variables to the result of `.get(..., "")`, the corresponding env variables are set to an empty value. This is an issue for some values, such as `AWS_CA_BUNDLE`, which should be set to a path pointing to a valid CA bundle. When set to an empty string, it is propagated all the way down to `botocore.httpsession.URLLib3Session._setup_ssl_cert`, which interprets it as `False` and disables verification. See https://github.com/boto/botocore/blob/6e0ec833714ed88d46e294048cdb0d3869eb2ab5/botocore/httpsession.py#L376-L382 Signed-off-by: Daniele Trifirò <dtrifiro@redhat.com>
…ve#3371) Signed-off-by: jooho <jlee@redhat.com>
…ve#3436) * feat: Allow to disable ingress creation for raw deployment mode Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * test Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * Add configs Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * codegen Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * python docs Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * update helm docs Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * undo changes in pkg/apis/serving/v1beta1/zz_generated.deepcopy.go Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * remove unnecessary changes Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * Empty-Commit Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * remove hf change Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * Update config/configmap Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * fix chart syntax Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * Empty-Commit Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> --------- Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
30a52f9
to
908018f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jooho Do you want to include kserve#3463?
@terrytangyuan yes! |
The raw deployment is not 100% working, right? |
What is not working? |
That combination that Daniele mentioned on yesterday's meeting. |
@terrytangyuan I think that @Jooho already picked that one here: #221. |
Because the config variable was renamed from `certificate` to `ca_bundle`. Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: israel-hdez, terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…gent-29 Red Hat Konflux update kserve-agent-29
What this PR does / why we need it:
Cherry pick: