Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from kserve:master #219

Merged
merged 16 commits into from
Feb 22, 2024

Conversation

pull[bot]
Copy link

@pull pull bot commented Feb 18, 2024

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

sivanantha321 and others added 4 commits February 17, 2024 22:56
* Bump golang.org/x/crypto to 0.19.0

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Bump knative.dev/serving to 0.40.1

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* go mod tidy

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

---------

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Some code of the E2Es assume the environment is GitHub, because it is referring to GitHub-specific variables.

This PR focuses on references to the `kserve/image-transformer` image. This image is built in the CI flow and made available to the runner, so that a pull from an external registry is not needed.

The references to this image are changed to an environment variable that is more agnostic to the runner, in an effort to make E2Es more compatible in other environments. The e2e-test.yml is modified to declare the new variable.

Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>
* Initial commit to support vllm as alternative backend

Signed-off-by: Gavrish Prabhu <gavrish.prabhu@nutanix.com>

* include minor fixes and readme changes

Signed-off-by: Gavrish Prabhu <gavrish.prabhu@nutanix.com>

* fix poetry lock issues

Signed-off-by: Gavrish Prabhu <gavrish.prabhu@nutanix.com>

* fix lint issues

Signed-off-by: Gavrish Prabhu <gavrish.prabhu@nutanix.com>

* use_vllm support True as default

Signed-off-by: Gavrish Prabhu <gavrish.prabhu@nutanix.com>

* refactor code and fix review comments

Signed-off-by: Gavrish Prabhu <gavrish.prabhu@nutanix.com>

* build failure - fix tests and install vllm part of dockerfile

Signed-off-by: Gavrish Prabhu <gavrish.prabhu@nutanix.com>

* fix poetry lock issue

Signed-off-by: Gavrish Prabhu <gavrish.prabhu@nutanix.com>

* include string constants

Signed-off-by: Gavrish Prabhu <gavrish.prabhu@nutanix.com>

* linting fix

Signed-off-by: Gavrish Prabhu <gavrish.prabhu@nutanix.com>

* fix review comments

Signed-off-by: Gavrish Prabhu <gavrish.prabhu@nutanix.com>

* fix tests

Signed-off-by: Gavrish Prabhu <gavrish.prabhu@nutanix.com>

* fix review comments

Signed-off-by: Gavrish Prabhu <gavrish.prabhu@nutanix.com>

* add support in vllm  for locally downloaded models

Signed-off-by: Gavrish Prabhu <gavrish.prabhu@nutanix.com>

* Update Readme

Signed-off-by: Gavrish Prabhu <gavrish.prabhu@nutanix.com>

* Update Readme

Signed-off-by: Gavrish Prabhu <gavrish.prabhu@nutanix.com>

* Update python/huggingfaceserver/README.md

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

---------

Signed-off-by: Gavrish Prabhu <gavrish.prabhu@nutanix.com>
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Co-authored-by: Dan Sun <dsun20@bloomberg.net>
Expose qpext aggregate metrics port

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Copy link

openshift-ci bot commented Feb 18, 2024

Hi @pull[bot]. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sivanantha321 and others added 7 commits February 18, 2024 15:45
* Bump paddlepaddle to 2.6.0

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Bump transformers to version 4.37.2

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Bump cryptography to version 42.0.2

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Bump fastapi to version 0.109.2

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Bump pillow to version 10.2.0

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Bump aiohttp to version 3.9.3

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Revert fastapi bump

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Bump ray serve to 2.9.2

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Pin alibi to >=0.9.4

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Fix alibi version

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

---------

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
* feat: Allow to disable ingress creation for raw deployment mode

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* test

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* Add configs

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* codegen

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* python docs

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* update helm docs

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* undo changes in pkg/apis/serving/v1beta1/zz_generated.deepcopy.go

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* remove unnecessary changes

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* Empty-Commit

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* remove hf change

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* Update config/configmap

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* fix chart syntax

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* Empty-Commit

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

---------

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
* build: Skip already downloaded Istio in quick_install.sh

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* Update quick_install.sh

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

---------

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
…rver (#3449)

* fix: HuggingFace predictor should not be recognized as multi-model server

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* add

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

---------

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
* Do not inject model agent for huggingface runtime

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Add option to return token type ids

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Add option to return token type ids

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Default model dir

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

---------

Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Add padding and truncation in huggingface tokenizer

Signed-off-by: Kevin Mingtarja <kevinm@hypermode.com>
Signed-off-by: Kevin Mingtarja <69668484+kevinmingtarja@users.noreply.github.com>
@israel-hdez
Copy link

/ok-to-test

yuzisun and others added 4 commits February 20, 2024 03:14
#3456)

* Fix model dir does not work with vllm

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Fix extra comma

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

---------

Signed-off-by: Dan Sun <dsun20@bloomberg.net>
…et (#3390)

* Fix azure workload identity federation by excluding azure client secret

Signed-off-by: Robbert van der Gugten <rvandergugten@deeploy.ml>

* comment code

Signed-off-by: Robbert van der Gugten <rvandergugten@deeploy.ml>

---------

Signed-off-by: Robbert van der Gugten <rvandergugten@deeploy.ml>
Co-authored-by: Robbert van der Gugten <rvandergugten@deeploy.ml>
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
@israel-hdez
Copy link

/retest

…#3463)

* change certificate field for s3 storageSecret in python

Signed-off-by: jooho <jlee@redhat.com>

* change the field name to ca_bundle that is the same pattern with aws

Signed-off-by: jooho <jlee@redhat.com>

---------

Signed-off-by: jooho <jlee@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm label Feb 21, 2024
@israel-hdez
Copy link

/retest

3 similar comments
@spolti
Copy link
Member

spolti commented Feb 22, 2024

/retest

@israel-hdez
Copy link

/retest

@spolti
Copy link
Member

spolti commented Feb 22, 2024

/retest

@israel-hdez
Copy link

/override ci/prow/e2e-fast ci/prow/e2e-slow

Copy link

openshift-ci bot commented Feb 22, 2024

@israel-hdez: Overrode contexts on behalf of israel-hdez: ci/prow/e2e-fast, ci/prow/e2e-slow

In response to this:

/override ci/prow/e2e-fast ci/prow/e2e-slow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm label Feb 22, 2024
Copy link

openshift-ci bot commented Feb 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: israel-hdez, pull[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 926a43c into opendatahub-io:master Feb 22, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

9 participants