Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync community master into odh master #148

Closed
wants to merge 11 commits into from

Conversation

spolti
Copy link
Member

@spolti spolti commented Dec 18, 2023

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Type of changes
Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Feature/Issue validation/testing:

Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A

  • Test B

  • Logs

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Checklist:

  • Have you added unit/e2e tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Release note:


Jooho and others added 10 commits December 8, 2023 14:22
* Add CA bundle configuration

Signed-off-by: Danilo Peixoto <danilopeixoto@outlook.com>

* Implement CA bundle volume mount

Signed-off-by: Danilo Peixoto <danilopeixoto@outlook.com>

* Update tests

Signed-off-by: Danilo Peixoto <danilopeixoto@outlook.com>

* Add default mount path

Signed-off-by: Danilo Peixoto <danilopeixoto@outlook.com>

* Update defaults

Signed-off-by: Danilo Peixoto <danilopeixoto@outlook.com>

* Update constants

Signed-off-by: Danilo Peixoto <danilopeixoto@outlook.com>

* Use constant

Signed-off-by: Danilo Peixoto <danilopeixoto@outlook.com>

* Implement tests

Signed-off-by: Danilo Peixoto <danilopeixoto@outlook.com>

* Rename volume

Signed-off-by: Danilo Peixoto <danilopeixoto@outlook.com>

* Fix name references

Signed-off-by: Danilo Peixoto <danilopeixoto@outlook.com>

* Update configmap

Signed-off-by: Danilo Peixoto <danilopeixoto@outlook.com>

* fix unit test for pr-3216

Signed-off-by: jooho <jlee@redhat.com>

* add a logic to mount cabundle secret to storage-initializer container

Signed-off-by: jooho <jlee@redhat.com>

* Correct failed conflict resolve of storage_initializer_injector.go

Signed-off-by: Christian Kadner <ckadner@us.ibm.com>

* Revert changes in go.sum

Signed-off-by: Christian Kadner <ckadner@us.ibm.com>

* Revert changes in zz_generated.deepcopy.go

Signed-off-by: Christian Kadner <ckadner@us.ibm.com>

* Revert changes in openapi_generated.go

Signed-off-by: Christian Kadner <ckadner@us.ibm.com>

* Revert changes in zz_generated.deepcopy.go

Signed-off-by: Christian Kadner <ckadner@us.ibm.com>

* convert Secret to ConfigMap for cabundle

Signed-off-by: jooho <jlee@redhat.com>

* update some sources to solve reviews

Signed-off-by: jooho <jlee@redhat.com>

* Add 'cabundle_configmap' to 'storage-config' StorageSpec

Signed-off-by: jooho <jlee@redhat.com>

* fix new comments

Signed-off-by: jooho <jlee@redhat.com>

* update to fix review comments

Signed-off-by: jooho <jlee@redhat.com>

---------

Signed-off-by: Danilo Peixoto <danilopeixoto@outlook.com>
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Signed-off-by: jooho <jlee@redhat.com>
Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
Signed-off-by: Jooho Lee <jlee@redhat.com>
Co-authored-by: Danilo Peixoto <danilopeixoto@outlook.com>
Co-authored-by: Dan Sun <dsun20@bloomberg.net>
Co-authored-by: Christian Kadner <ckadner@us.ibm.com>
Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
* Update Istio-Dex docs

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Add docs for auth using service account

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Fix kfserving name 

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

---------

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Co-authored-by: Dan Sun <dsun20@bloomberg.net>
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
…loadModel() (kserve#3295)

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
…rror in future (kserve#3272)

* Update ray serve version
Update tests to remove detached=false parameter

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

* Pinned `async-timeout` as direct dependency for python 3.11

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

---------

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
* Fix qpext hangs during shutdown

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Fix e2e qpext image build

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Revert vcs info stamping

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

---------

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
chore: Upgrade to XGBoost v2.0.2

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Copy link

openshift-ci bot commented Dec 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spolti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Spolti <fspolti@redhat.com>
@israel-hdez
Copy link

Unit tests are not passing... And it seems to be a lot of effort to fix.
Unless there is something urgent, I'd suggest to wait for my PR to be merged: kserve#3316.

Once it is merged, we can revert some customizations on ODH fork which would make the sync much more seamless.

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spolti
Copy link
Member Author

spolti commented Dec 29, 2023

closed in favor of #151

@spolti spolti closed this Dec 29, 2023
@spolti spolti deleted the sync branch December 29, 2023 13:54
Jooho pushed a commit to Jooho/kserve that referenced this pull request Feb 28, 2024
…p/component-updates/kserve-agent-28

Update kserve-agent-28 to 67edf69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants