-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] master from kserve:master #142
Conversation
* support grpc-v2 for torchserve runtime Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Format changes. Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> --------- Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Hi @pull[bot]. Thanks for your PR. I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
* Bump istio version to 1.19.4 Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * make generate Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> --------- Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
This makes the script fail when something in a pipe fails. With this `make deploy-dev` actually fail on the right line when something is failing instead of getting an unrelated error on on other scripts. For the record: `ko resolve` was failing because `KO_DOCKER_REPO` was unset. Signed-off-by: Daniele Trifirò <dtrifiro@redhat.com>
…re set in storage secret json (#3259) By setting environment variables to the result of `.get(..., "")`, the corresponding env variables are set to an empty value. This is an issue for some values, such as `AWS_CA_BUNDLE`, which should be set to a path pointing to a valid CA bundle. When set to an empty string, it is propagated all the way down to `botocore.httpsession.URLLib3Session._setup_ssl_cert`, which interprets it as `False` and disables verification. See https://github.com/boto/botocore/blob/6e0ec833714ed88d46e294048cdb0d3869eb2ab5/botocore/httpsession.py#L376-L382 Signed-off-by: Daniele Trifirò <dtrifiro@redhat.com>
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: israel-hdez, pull[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
0f92f64
into
opendatahub-io:master
See Commits and Changes for more details.
Created by pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )