Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P1] (optional) Test RawDeployment #6

Closed
heyselbi opened this issue Jun 19, 2023 · 7 comments
Closed

[P1] (optional) Test RawDeployment #6

heyselbi opened this issue Jun 19, 2023 · 7 comments
Assignees

Comments

@heyselbi
Copy link

heyselbi commented Jun 19, 2023

Goal:
The goal of the ticket is to create an alternative configuration option (additional KfDef or a parameter) to install/configure KServe in OpenShift via ODH to use plain k8s Deployment (aka RawDeployment mode).

More context:
The default deployment mechanism for KServe is using Knative and Istio but it is also possible to configure KServe to create plain Deployment object using RawDeployment mode.

@ReToCode did already an experiment using RawDeployment in OpenShift (see POC_RAW_DEPLOYMENTS.md) so it should work.

@heyselbi
Copy link
Author

@danielezonca could we add more details here? Or please tag someone who can.

@heyselbi heyselbi moved this from Backlog to Groomed Issues and Trackers in ODH Model Serving Planning Jul 11, 2023
@skonto
Copy link

skonto commented Jul 17, 2023

Probably you want to use #5 to test on a separate job.

@heyselbi heyselbi moved this from Groomed Issues to To-do This Sprint in ODH Model Serving Planning Jul 19, 2023
@danielezonca
Copy link

I agree with @skonto comment

@israel-hdez
Is it fine to assign this task to you?
Implementing #5 you should be able to enable the e2e test suite and if this covers also the RawDeployment, this ticket is automatically solved, if it doesn't (or there are issues to enable this test case) fine for me to move to 1.32 sprint.
Wdyt?

@israel-hdez
Copy link

I do agree that we can use the e2e suite to cover this ticket. And I'm OK assigning this one to me.

To keep work focused, I prefer to keep this open. On #5 I'm focused on Serverless. For RawDeployment, another cluster needs to be provisioned to run the tests. So, it is two different jobs/tasks.

@heyselbi
Copy link
Author

@israel-hdez could you update the Expected end date accordingly, based on your best estimation?

@israel-hdez
Copy link

@israel-hdez could you update the Expected end date accordingly, based on your best estimation?

I updated it to august 18.

@israel-hdez
Copy link

Upstream already covers RawDeployment, while in ODH we are not supporting this deployment mode yet.

For now, we will trust upstream would check correctness of RawDeployment (there are already itests). If, in the future, we have the need to support RawDeployment in ODH, we will revisit this feature.

Closing, for now.

@israel-hdez israel-hdez closed this as not planned Won't fix, can't repro, duplicate, stale Dec 11, 2023
@github-project-automation github-project-automation bot moved this from To-do/Groomed to Done in ODH Model Serving Planning Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: No status
Status: Done
Development

No branches or pull requests

4 participants