Add basic preflight checks as the first component in the pipeline #21
Conversation
JudeNiroshan
force-pushed
the
preflight-checks
branch
from
19bfb68 to
d22763f
Compare
| if (not repo_branch) and (repo_pr is None or repo_pr <= 0 ): | ||
| raise Exception("Both taxonomy repo branch and taxonomy pull request number cannot be empty") |
There was a problem hiding this comment.
This gets checked when you try to create the run. It will give an error if you try to proceed without a PR or branch.
Failed to create a new run: Failed to generate the ExecutionSpec: invalid pipeline job inputs: Invalid input error: input parameter repo_pr requires type double or integer, but the parameter value is not of number value type
Can remove this check
| raise Exception("Model name is missing in kfp-model-server configMap") | ||
| if not endpoint: | ||
| raise Exception("Model Server endpoint URL is missing in kfp-model-server configMap") | ||
|
|
There was a problem hiding this comment.
This will fail at the first step anyways if these params are not set correctly. Do we want to add in some additional checks here that may cause failures during the training and eval steps later on as well?
|
Thanks @JudeNiroshan I made a couple of comments. Can you rebase this PR as well. Thanks! |
JudeNiroshan
force-pushed
the
preflight-checks
branch
from
d22763f to
cec959a
Compare
|
Please install https://docs.astral.sh/ruff/installation/ on your system and run |
Address #19