add judge model details to standalone readme #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelClifford
requested changes
Oct 23, 2024
leseb
reviewed
Oct 23, 2024
| A judge model is assumed to be running external to the script. This is used for model evaluation. | ||
|
|
||
| The simplest way to provide details about a judge model server is with a Kubernetes secret. An example of how to serve a judge model can be found in | ||
| the [kubernetes-yaml](../kubernetes_yaml) folder. This folder contains an example for serving a model and also for downloading a model to an S3 |
There was a problem hiding this comment.
Are we sure we want to point at this directory? (What if this moves to another repo?) Can we link to the ServingRuntime doc instead?
There was a problem hiding this comment.
where's that doc? if it has the same info, sure
There was a problem hiding this comment.
I'm fine with keeping the reference here for now & updating this with a follow-up
There was a problem hiding this comment.
Signed-off-by: sallyom <somalley@redhat.com>
sallyom
force-pushed
the
update-readme
branch
from
3c517e2 to
bb85369
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@MichaelClifford @leseb ptal, adding additional clarity around judge server details.