Skip to content

Commit

Permalink
fix: Fix integration build/push for images (feast-dev#4923)
Browse files Browse the repository at this point in the history
fix integration build/push for images

Signed-off-by: Tommy Hughes <tohughes@redhat.com>
  • Loading branch information
tchughesiv authored Jan 15, 2025
1 parent 40b975b commit 695e49b
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 4 deletions.
6 changes: 6 additions & 0 deletions .github/workflows/java_master_only.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,12 @@ jobs:
run: echo "RELEASE_VERSION=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV
- name: Build image
run: make build-${{ matrix.component }}-docker REGISTRY=${REGISTRY} VERSION=${GITHUB_SHA}
- name: Login to Quay.io
uses: docker/login-action@v1
with:
registry: quay.io
username: ${{ secrets.QUAYIO_CI_USERNAME }}
password: ${{ secrets.QUAYIO_CI_TOKEN }}
- name: Push image
run: make push-${{ matrix.component }}-docker REGISTRY=${REGISTRY} VERSION=${GITHUB_SHA}
- name: Push development Docker image
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/master_only.yml
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
component: [ feature-server, feature-server-java, feature-transformation-server, feast-operator ]
component: [ feature-server-dev, feature-transformation-server, feast-operator ]
env:
MAVEN_CACHE: gs://feast-templocation-kf-feast/.m2.2020-08-19.tar
REGISTRY: quay.io/feastdev-ci
Expand Down
14 changes: 11 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -477,11 +477,11 @@ push-ci-docker:
docker push $(REGISTRY)/feast-ci:$(VERSION)

push-feature-server-docker:
docker push $(REGISTRY)/feature-server:$$VERSION
docker push $(REGISTRY)/feature-server:$(VERSION)

build-feature-server-docker:
docker buildx build --build-arg VERSION=$$VERSION \
-t $(REGISTRY)/feature-server:$$VERSION \
docker buildx build --build-arg VERSION=$(VERSION) \
-t $(REGISTRY)/feature-server:$(VERSION) \
-f sdk/python/feast/infra/feature_servers/multicloud/Dockerfile --load .

push-feature-transformation-server-docker:
Expand Down Expand Up @@ -531,6 +531,14 @@ build-feature-server-dev:
-t feastdev/feature-server:dev \
-f sdk/python/feast/infra/feature_servers/multicloud/Dockerfile.dev --load .

build-feature-server-dev-docker:
docker buildx build \
-t $(REGISTRY)/feature-server:$(VERSION) \
-f sdk/python/feast/infra/feature_servers/multicloud/Dockerfile.dev --load .

push-feature-server-dev-docker:
docker push $(REGISTRY)/feature-server:$(VERSION)

build-java-docker-dev:
make build-java-no-tests REVISION=dev
docker buildx build --build-arg VERSION=dev \
Expand Down

0 comments on commit 695e49b

Please sign in to comment.