Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-12831: Standardize file selection on pipeline editor #76

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

caponetto
Copy link

https://issues.redhat.com/browse/RHOAIENG-12831

Right-click on pipeline editor canvas and select "New node from Pipeline"

Current Behavior New Behavior
- List only files, not folders
- Cannot navigate between folders
- List files in the root folder if the pipeline file is in the root folder
- List files in the parent folder of the folder where the pipeline file is
- List files and folders
- Can navigate between folders
- List files in the folder where the pipeline file is

Node Properties panel - Inputs section

Current Behavior New Behavior
- List only files, not folders
- Cannot navigate between folders
- When there is a value for the input path, it lists the folder where the given input file path is
- When the value is empty, it lists files in the root if the pipeline file is in the root. Otherwise, it lists files in the parent folder of the folder where the pipeline file is
- List files and folders
- Can navigate between folders
- When there is a value for the input path, the current behavior is kept
- When the value is empty, it lists files in the folder where the pipeline file is

Node Properties panel - File Dependencies section

Current Behavior New Behavior
- List files and folders
- Can navigate between folders
- When there is a value for the Input path, it lists the folder where the given input file path is
- When the input path is empty, it lists files in the root if the pipeline file is in the root. Otherwise, it lists in the parent folder of the folder where the pipeline file is
- List files and folders
- Can navigate between folders
- When there is a value for the input path, the current behavior is kept
- When the value is empty, it lists files in the folder where the pipeline file is

@caponetto caponetto requested a review from paulovmr October 23, 2024 17:43
@paulovmr paulovmr merged commit aa27131 into opendatahub-io:main Oct 24, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants