Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-13877: Fix kernel dropdown style for Dark theme #68

Merged
merged 1 commit into from
Oct 11, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix kernel dropdown style
  • Loading branch information
caponetto committed Oct 11, 2024
commit 9591f9a0da1ac99692cadb92a403aef0d1c4ac9e
11 changes: 3 additions & 8 deletions packages/script-editor/src/KernelDropdown.tsx
Original file line number Diff line number Diff line change
@@ -16,6 +16,7 @@

import { ReactWidget } from '@jupyterlab/apputils';
import { KernelSpec } from '@jupyterlab/services';
import { HTMLSelect } from '@jupyterlab/ui-components';

import React, {
forwardRef,
@@ -25,8 +26,6 @@ import React, {
RefObject
} from 'react';

const KERNEL_SELECT_CLASS = 'elyra-ScriptEditor-KernelSelector';

export interface ISelect {
getSelection: () => string;
}
@@ -73,13 +72,9 @@ const DropDown = forwardRef<ISelect, IProps>(
};

return (
<select
className={KERNEL_SELECT_CLASS}
onChange={handleSelection}
value={selection}
>
<HTMLSelect onChange={handleSelection} value={selection}>
{kernelOptions}
</select>
</HTMLSelect>
);
}
);
18 changes: 0 additions & 18 deletions packages/script-editor/style/index.css
Original file line number Diff line number Diff line change
@@ -74,21 +74,3 @@ button.elyra-ScriptEditor-scrollBottom:hover {
.jp-Document .jp-Toolbar.elyra-ScriptEditor-Toolbar {
justify-content: flex-start;
}

/* TODO: fix selector not beig picked up */
/* fix border style in safari */
.elyra-ScriptEditor-KernelSelector select {
background-color: initial;
border: none;
border-radius: 0;
box-shadow: none;
color: var(--jp-ui-font-color0);
display: block;
font-size: var(--jp-ui-font-size1);
height: 24px;
line-height: 14px;
padding: 0 25px 0 10px;
text-align: left;
-moz-appearance: none;
-webkit-appearance: none;
}
Loading