Upgrade requirement package with most compatible #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
…#3240) * nbconvert version without lxml requirement. Update runtime library requirements and pyproject dependencies to be more current. --------- Signed-off-by: shalberd <21118431+shalberd@users.noreply.github.com>
jstourac
reviewed
Sep 26, 2024
| @@ -1062,7 +1062,7 @@ def _compose_container_command_args( | |||
| # meant for the opendatahub-io/Data-science-pipelines v2 use case | |||
| # and should not be opened as PR against upstream Elyra | |||
| elyra_github_org = os.getenv("ELYRA_GITHUB_ORG", "opendatahub-io") | |||
| elyra_github_branch = os.getenv("ELYRA_GITHUB_BRANCH", "dspv2" if "dev" in __version__ else __version__) | |||
| elyra_github_branch = os.getenv("ELYRA_GITHUB_BRANCH", "jupyterlab4" if "dev" in __version__ else __version__) | |||
There was a problem hiding this comment.
If this is a temporary change - should we have some comment with here?
paulovmr
approved these changes
Sep 26, 2024
paulovmr
pushed a commit
that referenced
this pull request
Sep 26, 2024
* chores: set temporary default for elyra-branch as jupyterlab4 Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com> * Dependency updates including nbconvert version without lxml (elyra-ai#3240) * nbconvert version without lxml requirement. Update runtime library requirements and pyproject dependencies to be more current. --------- Signed-off-by: shalberd <21118431+shalberd@users.noreply.github.com> --------- Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com> Signed-off-by: shalberd <21118431+shalberd@users.noreply.github.com> Co-authored-by: Sven Thoms <21118431+shalberd@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade requirement package with most compatible
Related-to: https://issues.redhat.com/browse/RHOAIENG-13044
Cherry-picked upstream fixes: nbconvert version without lxml requirement and more elyra-ai/elyra#3240
This issue occurs on jupyterlab4 branch as well.
change default elyra_github_branch to be pointed at jupyterlab4, till we do dev releases.