Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the run_url with experiment info included #20

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

harshad16
Copy link
Member

Set the run_url with experiment info included

The run_url is set in the format of: {experiment_id}/runs/{run_id}
Example:

https://rhods-dashboard-redhat-ods-applications.apps.datahub.redhat.com/experiments/experiment/024e260b-75e9-407e-9e8d-3974320c06dc/runs/b6c920a2-a3de-452c-bf58-88d46f3da65b

Related-to: https://issues.redhat.com/browse/RHOAIENG-8398

Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
@harshad16
Copy link
Member Author

Merging to get the release out

@harshad16 harshad16 merged commit 71570d3 into opendatahub-io:dspv2 Jun 21, 2024
7 of 13 checks passed
@@ -421,7 +421,7 @@ def process(self, pipeline):

self.log_pipeline_info(
pipeline_name,
f"pipeline submitted: {public_api_endpoint}/{run.run_id}",
f"pipeline submitted: {public_api_endpoint}/{experiment.experiment_id}/runs/{run.run_id}",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my current testing, looks like the property {public_api_endpoint} already contains the / at the end since I can see a following resulted link:

https://.../experiments/test//023c423d-84dc-411b-a61f-38b7cbd3a961/runs/bf8fa2a6-0803-4d12-b6fb-fde2be209b0e

Anyway, I don't think it's a big issue and in the end, it's a safer approach, so I don't find it as a problem now.

paulovmr pushed a commit that referenced this pull request Sep 26, 2024
Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants