UPSTREAM: <carry>: use asc artifact ordering by default. #66

HumairAK · 2024-07-18T15:50:04Z

We should set order_by to asc by default.

dsp-developers · 2024-07-18T15:50:58Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 1 commits between 7d7659c9fb731b1610570e2dd3d056d025e1600e...ce386ab9e821e3515311b2d8cc1ee8320a53639e

dsp-developers · 2024-07-18T15:58:12Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
ERROR: couldn't find commits from 7d7659c9fb731b1610570e2dd3d056d025e1600e..53cd02e80cb54170c84c955dd857b8cebe9fc143: error executing git log: fatal: Invalid revision range 7d7659c9fb731b1610570e2dd3d056d025e1600e..53cd02e80cb54170c84c955dd857b8cebe9fc143
: exit status 128

dsp-developers · 2024-07-18T15:58:22Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 1 commits between 7d7659c9fb731b1610570e2dd3d056d025e1600e...336658f8138aa2509b4c173883865f62addf3707

dsp-developers · 2024-07-18T15:59:43Z

A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-66
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-66
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-66
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-66
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-66
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-66

dsp-developers · 2024-07-18T15:59:43Z

An OCP cluster where you are logged in as cluster admin is required.

The Data Science Pipelines team recommends testing this using the Data Science Pipelines Operator. Check here for more information on using the DSPO.

To use and deploy a DSP stack with these images (assuming the DSPO is deployed), first save the following YAML to a file named dspa.pr-66.yaml:

apiVersion: datasciencepipelinesapplications.opendatahub.io/v1alpha1
kind: DataSciencePipelinesApplication
metadata:
  name: pr-66
spec:
  dspVersion: v2
  apiServer:
    image: "quay.io/opendatahub/ds-pipelines-api-server:pr-66"
    argoDriverImage: "quay.io/opendatahub/ds-pipelines-driver:pr-66"
    argoLauncherImage: "quay.io/opendatahub/ds-pipelines-launcher:pr-66"
  persistenceAgent:
    image: "quay.io/opendatahub/ds-pipelines-persistenceagent:pr-66"
  scheduledWorkflow:
    image: "quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-66"
  mlmd:  
    deploy: true  # Optional component
    grpc:
      image: "quay.io/opendatahub/mlmd-grpc-server:latest"
    envoy:
      image: "registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2"
  mlpipelineUI:
    deploy: true  # Optional component 
    image: "quay.io/opendatahub/ds-pipelines-frontend:pr-66"
  objectStorage:
    minio:
      deploy: true
      image: 'quay.io/opendatahub/minio:RELEASE.2019-08-14T20-37-41Z-license-compliance'

Then run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines.git
cd data-science-pipelines/
git fetch origin pull/66/head
git checkout -b pullrequest ce386ab9e821e3515311b2d8cc1ee8320a53639e
oc apply -f dspa.pr-66.yaml

More instructions here on how to deploy and test a Data Science Pipelines Application.

VaniHaripriya · 2024-07-18T16:03:56Z

/lgtm

gmfrasca · 2024-07-18T16:04:56Z

backend/src/apiserver/server/artifact_server.go

@@ -85,10 +85,8 @@ func (s *ArtifactServer) ListArtifacts(ctx context.Context, r *apiv2beta1.ListAr
 	switch r.OrderBy {


if orderByAsc is true anyways (and we're removing the default case), why bother with a case-switch when we can just set orderByAsc to false if desc

DharmitD

order_by labels updated correctly everywhere, CI tests passing, API reference page (swagger) updated.

/lgtm

dsp-developers · 2024-07-18T16:07:14Z

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-66
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-66
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-66
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-66
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-66
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-66

dsp-developers · 2024-07-18T16:07:27Z

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-66
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-66
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-66
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-66
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-66
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-66

Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>

dsp-developers · 2024-07-18T16:10:13Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 1 commits between 7d7659c9fb731b1610570e2dd3d056d025e1600e...2f3aada5c079fca41e5ee633cffb68c6a6f328b8

dsp-developers · 2024-07-18T16:11:03Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 1 commits between 7d7659c9fb731b1610570e2dd3d056d025e1600e...41c133e5ddaba76e4217c16772dc59f0a0993198

dsp-developers · 2024-07-18T16:19:06Z

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-66
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-66
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-66
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-66
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-66
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-66

dsp-developers · 2024-07-18T16:20:03Z

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-66
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-66
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-66
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-66
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-66
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-66

openshift-ci · 2024-07-18T16:42:58Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gmfrasca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [gmfrasca]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dsp-developers · 2024-07-18T16:48:49Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 0 commits between bbfb5897533403b38ad8956424931868c103b0b0...41c133e5ddaba76e4217c16772dc59f0a0993198

openshift-ci bot requested review from rimolive and VaniHaripriya July 18, 2024 15:50

HumairAK force-pushed the RHOAIENG-8225-bug-fix branch 2 times, most recently from 53cd02e to 336658f Compare July 18, 2024 15:57

openshift-ci bot assigned VaniHaripriya Jul 18, 2024

openshift-ci bot added the lgtm label Jul 18, 2024

gmfrasca reviewed Jul 18, 2024

View reviewed changes

DharmitD reviewed Jul 18, 2024

View reviewed changes

openshift-ci bot assigned DharmitD Jul 18, 2024

HumairAK force-pushed the RHOAIENG-8225-bug-fix branch from 336658f to 2f3aada Compare July 18, 2024 16:09

openshift-ci bot removed the lgtm label Jul 18, 2024

UPSTREAM: <carry>: use asc artifact ordering by default.

41c133e

Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>

HumairAK force-pushed the RHOAIENG-8225-bug-fix branch from 2f3aada to 41c133e Compare July 18, 2024 16:10

HumairAK requested a review from gmfrasca July 18, 2024 16:14

gmfrasca approved these changes Jul 18, 2024

View reviewed changes

openshift-ci bot assigned gmfrasca Jul 18, 2024

openshift-ci bot added the lgtm label Jul 18, 2024

openshift-ci bot added the approved label Jul 18, 2024

openshift-merge-bot bot merged commit bbfb589 into opendatahub-io:master Jul 18, 2024
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UPSTREAM: <carry>: use asc artifact ordering by default. #66

UPSTREAM: <carry>: use asc artifact ordering by default. #66

HumairAK commented Jul 18, 2024

dsp-developers commented Jul 18, 2024

dsp-developers commented Jul 18, 2024

dsp-developers commented Jul 18, 2024

dsp-developers commented Jul 18, 2024

dsp-developers commented Jul 18, 2024

VaniHaripriya commented Jul 18, 2024

gmfrasca Jul 18, 2024 •

edited

Loading

HumairAK Jul 18, 2024

DharmitD left a comment

dsp-developers commented Jul 18, 2024

dsp-developers commented Jul 18, 2024

dsp-developers commented Jul 18, 2024

dsp-developers commented Jul 18, 2024

dsp-developers commented Jul 18, 2024

dsp-developers commented Jul 18, 2024

openshift-ci bot commented Jul 18, 2024

dsp-developers commented Jul 18, 2024

		@@ -85,10 +85,8 @@ func (s ArtifactServer) ListArtifacts(ctx context.Context, r apiv2beta1.ListAr
		switch r.OrderBy {

UPSTREAM: <carry>: use asc artifact ordering by default. #66

UPSTREAM: <carry>: use asc artifact ordering by default. #66

Conversation

HumairAK commented Jul 18, 2024

dsp-developers commented Jul 18, 2024

Commit Checker results:

dsp-developers commented Jul 18, 2024

Commit Checker results:

dsp-developers commented Jul 18, 2024

Commit Checker results:

dsp-developers commented Jul 18, 2024

dsp-developers commented Jul 18, 2024

VaniHaripriya commented Jul 18, 2024

gmfrasca Jul 18, 2024 • edited Loading

Choose a reason for hiding this comment

HumairAK Jul 18, 2024

Choose a reason for hiding this comment

DharmitD left a comment

Choose a reason for hiding this comment

dsp-developers commented Jul 18, 2024

dsp-developers commented Jul 18, 2024

dsp-developers commented Jul 18, 2024

Commit Checker results:

dsp-developers commented Jul 18, 2024

Commit Checker results:

dsp-developers commented Jul 18, 2024

dsp-developers commented Jul 18, 2024

openshift-ci bot commented Jul 18, 2024

dsp-developers commented Jul 18, 2024

Commit Checker results:

gmfrasca Jul 18, 2024 •

edited

Loading