Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: <carry>: chore(backend): Rename UpdateLastRun -> SetLastRunTimestamp #59

Merged
merged 1 commit into from
Jul 3, 2024
Merged

UPSTREAM: <carry>: chore(backend): Rename UpdateLastRun -> SetLastRunTimestamp #59

merged 1 commit into from
Jul 3, 2024

Conversation

gregsheremeta
Copy link

Description of your changes:

follup up to bf77909. Rename UpdateLastRun -> SetLastRunTimestamp

also tweak a related log message

/assign @HumairAK

Checklist:

@openshift-ci openshift-ci bot requested review from DharmitD and gmfrasca June 27, 2024 11:18
@gregsheremeta gregsheremeta changed the title chore(backend): Renamed UpdateLastRun -> SetLastRunTimestamp chore(backend): Rename UpdateLastRun -> SetLastRunTimestamp Jun 27, 2024
@dsp-developers
Copy link

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
ERROR: couldn't find commits from dadfb38393ce96cb7dc1eac60428d66f0e3f1933..f39fb24eb45ba7c0b13c85c8f80d07aef7d96024: error executing git log: fatal: Invalid revision range dadfb38393ce96cb7dc1eac60428d66f0e3f1933..f39fb24eb45ba7c0b13c85c8f80d07aef7d96024
: exit status 128

@dsp-developers
Copy link

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 1 commits between dadfb38393ce96cb7dc1eac60428d66f0e3f1933...dd1c5cc0630e9565ea0858656e5dac4d90773252

UPSTREAM commit dd1c5cc has invalid summary chore(backend): Rename UpdateLastRun -> SetLastRunTimestamp.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert

@gregsheremeta
UPSTREAM: <carry>: chore(backend): Rename UpdateLastRun -> SetLastRun…
63b5a63 
…Timestamp

follup up to bf77909. Rename UpdateLastRun -> SetLastRunTimestamp

also tweak a related log message

Signed-off-by: Greg Sheremeta <gshereme@redhat.com>
@gregsheremeta gregsheremeta changed the title chore(backend): Rename UpdateLastRun -> SetLastRunTimestamp UPSTREAM: <carry>: chore(backend): Rename UpdateLastRun -> SetLastRunTimestamp Jun 27, 2024
@dsp-developers
Copy link

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 1 commits between dadfb38393ce96cb7dc1eac60428d66f0e3f1933...63b5a638a047098561549f735b97138639980e57

@dsp-developers
Copy link

A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-59
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-59
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-59
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-59
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-59
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-59

@dsp-developers
Copy link

An OCP cluster where you are logged in as cluster admin is required.

The Data Science Pipelines team recommends testing this using the Data Science Pipelines Operator. Check here for more information on using the DSPO.

To use and deploy a DSP stack with these images (assuming the DSPO is deployed), first save the following YAML to a file named dspa.pr-59.yaml:

apiVersion: datasciencepipelinesapplications.opendatahub.io/v1alpha1
kind: DataSciencePipelinesApplication
metadata:
  name: pr-59
spec:
  dspVersion: v2
  apiServer:
    image: "quay.io/opendatahub/ds-pipelines-api-server:pr-59"
    argoDriverImage: "quay.io/opendatahub/ds-pipelines-driver:pr-59"
    argoLauncherImage: "quay.io/opendatahub/ds-pipelines-launcher:pr-59"
  persistenceAgent:
    image: "quay.io/opendatahub/ds-pipelines-persistenceagent:pr-59"
  scheduledWorkflow:
    image: "quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-59"
  mlmd:  
    deploy: true  # Optional component
    grpc:
      image: "quay.io/opendatahub/mlmd-grpc-server:latest"
    envoy:
      image: "registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2"
  mlpipelineUI:
    deploy: true  # Optional component 
    image: "quay.io/opendatahub/ds-pipelines-frontend:pr-59"
  objectStorage:
    minio:
      deploy: true
      image: 'quay.io/opendatahub/minio:RELEASE.2019-08-14T20-37-41Z-license-compliance'

Then run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines.git
cd data-science-pipelines/
git fetch origin pull/59/head
git checkout -b pullrequest f39fb24eb45ba7c0b13c85c8f80d07aef7d96024
oc apply -f dspa.pr-59.yaml

More instructions here on how to deploy and test a Data Science Pipelines Application.

@dsp-developers
Copy link

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-59
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-59
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-59
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-59
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-59
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-59

1 similar comment
@dsp-developers
Copy link

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-59
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-59
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-59
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-59
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-59
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-59

hbelmiro
hbelmiro reviewed Jul 3, 2024
View reviewed changes
Copy link

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 3, 2024
@HumairAK
Copy link

HumairAK commented Jul 3, 2024

/approve

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jul 3, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit b775d3c into opendatahub-io:master Jul 3, 2024
3 checks passed
@dsp-developers
Copy link

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 0 commits between b775d3c0f9dc220b65b0a35b48a3b41a07a9475a...63b5a638a047098561549f735b97138639980e57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbelmiro hbelmiro hbelmiro left review comments

@DharmitD DharmitD Awaiting requested review from DharmitD

@gmfrasca gmfrasca Awaiting requested review from gmfrasca

Assignees

@HumairAK HumairAK

@hbelmiro hbelmiro

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gregsheremeta @dsp-developers @HumairAK @hbelmiro