Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final fix for Commit Checker GH Action #50

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Final fix for Commit Checker GH Action #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/commit-check-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ on:
- completed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nitpick but version and commit checker are spelled incorrectly in the commit checker error message: rimolive#2 (comment)

could you add that fix as part of this PR?

env:
QUAY_ORG: opendatahub
QUAY_ID: ${{ secrets.QUAY_ROBOT_USERNAME }}
QUAY_TOKEN: ${{ secrets.QUAY_ROBOT_TOKEN }}
GH_USER_EMAIL: 140449482+dsp-developers@users.noreply.github.com
GH_USER_NAME: dsp-developers
jobs:
Expand Down Expand Up @@ -79,6 +77,7 @@ jobs:
run: |
git config user.email "${{ env.GH_USER_EMAIL }}"
git config user.name "${{ env.GH_USER_NAME }}"
gh pr checkout ${{ env.PR_NUMBER }}

cat <<"EOF" >> /tmp/body-file.txt
### Commit Checker results:
Expand All @@ -89,6 +88,9 @@ jobs:
you adhere to the commit checker formatting
```
EOF

echo "\`\`\`" >> /tmp/body-file.txt
podman run -q -v ${{ github.workspace }}:/src/app-root quay.io/rmartine/commitchecker:latest --start ${{ steps.get-commits.outputs.master_commit_hash }} --end ${{ steps.get-commits.outputs.last_commit_hash }} >> /tmp/body-file.txt 2>&1 || true
echo "\`\`\`" >> /tmp/body-file.txt

gh pr comment ${{ env.PR_NUMBER }} --body-file /tmp/body-file.txt
Loading