-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Commit Checker to get the PR last commit #47
Change Commit Checker to get the PR last commit #47
Conversation
@@ -62,15 +62,15 @@ jobs: | |||
needs: fetch-data | |||
env: | |||
PR_NUMBER: ${{ needs.fetch-data.outputs.pr_number }} | |||
PR_HASH: ${{ needs.fetch-data.outputs.head_sha }} | |||
steps: | |||
- uses: actions/checkout@v3 | |||
- name: Get Commits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest adding a step to include fetch-depth: 0
here, to fetch all history for all branches and tags.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or a git fetch --all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need all branch history for this, we're just comparing main branch with the pr sha commit
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HumairAK The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Commit Checker results: |
Description of your changes:
Checklist: