Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Commit Checker to get the PR last commit #47

Merged
merged 1 commit into from
May 29, 2024

Conversation

rimolive
Copy link

Description of your changes:

Checklist:

@@ -62,15 +62,15 @@ jobs:
needs: fetch-data
env:
PR_NUMBER: ${{ needs.fetch-data.outputs.pr_number }}
PR_HASH: ${{ needs.fetch-data.outputs.head_sha }}
steps:
- uses: actions/checkout@v3
- name: Get Commits
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest adding a step to include fetch-depth: 0 here, to fetch all history for all branches and tags.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or a git fetch --all

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need all branch history for this, we're just comparing main branch with the pr sha commit

@HumairAK
Copy link

/lgtm
/approve

@HumairAK HumairAK merged commit 7127a61 into opendatahub-io:master May 29, 2024
1 of 2 checks passed
@openshift-ci openshift-ci bot added the lgtm label May 29, 2024
Copy link

openshift-ci bot commented May 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dsp-developers
Copy link

Commit Checker results:
==== These are the results of the commit checker scans ====
==== If these are not commits from upstream kfp, then ====
==== please ensure you adhere to the commit checker formatting ====
$(podman run -q -v /home/runner/work/data-science-pipelines/data-science-pipelines:/src/app-root quay.io/rmartine/commitchecker:latest --start 7127a61 --end 47fb475)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants