Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick of (#11714): Ignore empty PULL_NUMBER environment variables in SDK tests #146

Merged

Conversation

mprahl
Copy link

@mprahl mprahl commented Feb 28, 2025

Description of your changes:

Cherry-pick of kubeflow@a7ec34f.

On pushes to the master branch, PULL_NUMBER was an empty string.

Checklist:

…#11714)

On pushes to the master branch, PULL_NUMBER was an empty string.

Signed-off-by: mprahl <mprahl@users.noreply.github.com>
(cherry picked from commit a7ec34f)
@openshift-ci openshift-ci bot requested review from HumairAK and rimolive February 28, 2025 18:54
@mprahl
Copy link
Author

mprahl commented Feb 28, 2025

/cc @hbelmiro

@openshift-ci openshift-ci bot requested a review from hbelmiro February 28, 2025 18:55
Copy link

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Feb 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hbelmiro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit f74c259 into opendatahub-io:master Feb 28, 2025
23 checks passed
@dsp-developers
Copy link

A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-146
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-146
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-146
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-146
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-146
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-146

@dsp-developers
Copy link

An OCP cluster where you are logged in as cluster admin is required.

The Data Science Pipelines team recommends testing this using the Data Science Pipelines Operator. Check here for more information on using the DSPO.

To use and deploy a DSP stack with these images (assuming the DSPO is deployed), first save the following YAML to a file named dspa.pr-146.yaml:

apiVersion: datasciencepipelinesapplications.opendatahub.io/v1alpha1
kind: DataSciencePipelinesApplication
metadata:
  name: pr-146
spec:
  dspVersion: v2
  apiServer:
    image: "quay.io/opendatahub/ds-pipelines-api-server:pr-146"
    argoDriverImage: "quay.io/opendatahub/ds-pipelines-driver:pr-146"
    argoLauncherImage: "quay.io/opendatahub/ds-pipelines-launcher:pr-146"
  persistenceAgent:
    image: "quay.io/opendatahub/ds-pipelines-persistenceagent:pr-146"
  scheduledWorkflow:
    image: "quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-146"
  mlmd:  
    deploy: true  # Optional component
    grpc:
      image: "quay.io/opendatahub/mlmd-grpc-server:latest"
    envoy:
      image: "registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2"
  mlpipelineUI:
    deploy: true  # Optional component 
    image: "quay.io/opendatahub/ds-pipelines-frontend:pr-146"
  objectStorage:
    minio:
      deploy: true
      image: 'quay.io/opendatahub/minio:RELEASE.2019-08-14T20-37-41Z-license-compliance'

Then run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines.git
cd data-science-pipelines/
git fetch origin pull/146/head
git checkout -b pullrequest f455c53d9030a1ef4f7b5380b82dfa99f8da883a
oc apply -f dspa.pr-146.yaml

More instructions here on how to deploy and test a Data Science Pipelines Application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants