-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add/Enable Customizable Sample Pipeline to APIServer #88
Add/Enable Customizable Sample Pipeline to APIServer #88
Conversation
979e6da
to
77fbdff
Compare
@gmfrasca can you rebase? that' why the e2e failed. |
- Create new bool .APIServer.EnableSamplePipeline. Default: true - Conditionnally include custom SamplePipeline if bool is set to true
Tested, sample configs show up when Some additional notes:
This effectively means you can only "load" the samples by setting What I would expect to happen is, when I set /lgtm |
/retest @HumairAK : I think i agree that this is outside the scope of this work. Reasoning being that I believe following the equivalent process with the base flipcoin example remains the same (stand up a DSPA, delete sample pipeline, delete apiserver pod and sample will remain missing in new apiserver). Additionally, getting too far in the weeds would mean having DSPO manually handling DB entries, which will lead to a very messy Operator code with a lot of breaking points, and not a great deal of value add in return. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anishasthana The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Allows us to override the default pipeline, in this case with a more data-science applicable example
Description
Introduce the sample-config and sample-pipeline ConfigMaps, which are mounted as volumes on the APIServer pod. these contain overrides for
sampel_config.json
and a compiled Tekton pipeline showing a simple Iris training run example. This shouldn't be merged before the matching (DSP PR)[https://github.com/opendatahub-io/data-science-pipelines/pull/80] which provides the py source code to the pipeline (else there will be a dead link in the sample pipeline descriptionHow Has This Been Tested?
Built a dev image of the DSPO, which can be used to override the image defined in the controller-manager Deployment in odh-applications. From there, create a new DSPA using the dspa_simple.yaml definition and verify flip-coin example has been replaced with an iris-training example.
Merge criteria: