Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix typos and improve grammar of README.md #717

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

gmfrasca
Copy link
Member

The issue resolved by this Pull Request:

Resolves #annoyance

Description of your changes:

Add context and improve grammar of prereqs and installation instructions in README

Testing instructions

RTD

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Signed-off-by: Giulio Frasca <gfrasca@redhat.com>
README.md Outdated Show resolved Hide resolved
@VaniHaripriya
Copy link
Contributor

/lgtm

Co-authored-by: Francisco Arceo <farceo@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm label Oct 10, 2024
@HumairAK
Copy link
Contributor

/approve

Copy link
Member

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/Approve

Copy link
Contributor

openshift-ci bot commented Oct 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DharmitD, franciscojavierarceo, HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit eea26ea into opendatahub-io:main Oct 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants