Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Remove v1 fields and reconcile logic from dspo #712

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Chore: Remove v1 fields and reconcile logic from dspo #712

wants to merge 2 commits into from

Commits on Oct 18, 2024

  1. remove dsp v1 

    This change adds a new apiversion "v1", which will remove all the dsp "v1" related fields, and also defaults to dsp "v2". The new apiversion is set as the stored version, however k8s will continue to serve v1alpha1, however it is deprecated.

All tests are updated acordingly.

Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
    @HumairAK
    HumairAK committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    cd6d5a6 View commit details
    Browse the repository at this point in the history

  2. Set dsp-version label on managed resources 

    This change makes it so that new reconciles on dspa owned resources are
labelled with a dsp-version=<dspa-version> label. This is to allow for
the dspa selectively watch (for manual WatchesRawSources) on resources
that are descendents of DSPAs with .spec.dspVersion set to supported
versions.

Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
    @HumairAK
    HumairAK committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    aaf3510 View commit details
    Browse the repository at this point in the history