Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow DSPO test suite be running with RHOAI #703

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

diegolovison
Copy link
Contributor

@diegolovison diegolovison commented Sep 18, 2024

The issue resolved by this Pull Request:

Break down the solution for #RHOAIENG-10212 into smaller PRs to facilitate review.

Description of your changes:

The goal of test.sh --rhoai is to be to run the DSPO test suite with a previous RHOAI installed.

Testing instructions

  • Have an OpenShift cluster with RHOAI installed and in the terminal do the following
  • oc login ...
  • export GIT_WORKSPACE=.....
  • test.sh --rhoai

The output must be

--- PASS: TestIntegrationTestSuite (350.21s)
    --- PASS: TestIntegrationTestSuite/TestAPIServerDeployment (1.89s)
        --- PASS: TestIntegrationTestSuite/TestAPIServerDeployment/Should_successfully_fetch_pipelines (0.47s)
        --- PASS: TestIntegrationTestSuite/TestAPIServerDeployment/Should_successfully_upload_a_pipeline (0.91s)
        --- PASS: TestIntegrationTestSuite/TestAPIServerDeployment/Should_successfully_upload_a_pipeline_with_custom_pip_server (0.50s)
    --- PASS: TestIntegrationTestSuite/TestDSPADeployment (1.05s)
        --- PASS: TestIntegrationTestSuite/TestDSPADeployment/with_default_MariaDB_and_Minio (1.05s)
            --- PASS: TestIntegrationTestSuite/TestDSPADeployment/with_default_MariaDB_and_Minio/should_have_6_pods (0.45s)
            --- PASS: TestIntegrationTestSuite/TestDSPADeployment/with_default_MariaDB_and_Minio/should_have_a_ready_ds-pipeline-dspa-ext_deployment (0.30s)
            --- PASS: TestIntegrationTestSuite/TestDSPADeployment/with_default_MariaDB_and_Minio/should_have_a_ready_ds-pipeline-persistenceagent-dspa-ext_deployment (0.15s)
            --- PASS: TestIntegrationTestSuite/TestDSPADeployment/with_default_MariaDB_and_Minio/should_have_a_ready_ds-pipeline-scheduledworkflow-dspa-ext_deployment (0.15s)
    --- PASS: TestIntegrationTestSuite/TestFetchExperiments (0.15s)
        --- PASS: TestIntegrationTestSuite/TestFetchExperiments/Should_successfully_fetch_experiments (0.15s)
    --- PASS: TestIntegrationTestSuite/TestPipelineSuccessfulRun (327.14s)
        --- PASS: TestIntegrationTestSuite/TestPipelineSuccessfulRun/Should_create_a_Pipeline_Run (248.24s)
        --- PASS: TestIntegrationTestSuite/TestPipelineSuccessfulRun/Should_create_a_Pipeline_Run_using_custom_pip_server (78.90s)
PASS
ok  	github.com/opendatahub-io/data-science-pipelines-operator/tests	350.219s

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Contributor

openshift-ci bot commented Sep 18, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@HumairAK
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Sep 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit a9974ff into opendatahub-io:main Sep 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants