-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move kind-integration.sh content to tests.sh and target environment for testing #702
Conversation
e90a4d9
to
3e58e36
Compare
/approve will let @rimolive lgtm it |
/hold |
/lgtm |
…or testing The goal of test.sh is to be the starting point for allowing a test be running to the following target: kind, fresh OpenShift, an OpenShift cluster with RHOAI installed.
/unhold |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HumairAK, rimolive The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The issue resolved by this Pull Request:
Break down the solution for #RHOAIENG-10212 into smaller PRs to facilitate review.
Description of your changes:
The goal of test.sh is to be the starting point for allowing a test to be running to the following target: kind, fresh OpenShift, an OpenShift cluster with RHOAI installed.
How to review:
kind-integration.sh
was copied totest.sh
test.sh
sh tests.sh --kind
--openshift
parameter and implementationWhy this should be merged
--openshift
. Having the base well defined and agreement from the team we can move forward and avoid rework. There are multiple ways to create a bash script and we should use one that the team is more comfortable with.Questions
Testing instructions
If GHA action passes, all good. No manual testing is required.
Checklist