Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move kind-integration.sh content to tests.sh and target environment for testing #702

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

diegolovison
Copy link
Contributor

@diegolovison diegolovison commented Sep 17, 2024

The issue resolved by this Pull Request:

Break down the solution for #RHOAIENG-10212 into smaller PRs to facilitate review.

Description of your changes:

The goal of test.sh is to be the starting point for allowing a test to be running to the following target: kind, fresh OpenShift, an OpenShift cluster with RHOAI installed.

How to review:

  • The content of kind-integration.sh was copied to test.sh
  • Functions were created into test.sh
  • A new way to call the script was created sh tests.sh --kind
  • In the next PR, we are introducing the --openshift parameter and implementation

Why this should be merged

  • No manual testing is required
  • Defined a new way to call the script that will be the base for --openshift. Having the base well defined and agreement from the team we can move forward and avoid rework. There are multiple ways to create a bash script and we should use one that the team is more comfortable with.

Questions

  • Explain the targets and the difference: target: kind, fresh OpenShift, an OpenShift cluster with RHOAI installed.
    • kind: The script will create all namespaces and set up all required dependencies. Example: routes, CRDs,
    • Fresh OpenShift: The script will ( next PR ) create all namespaces required but will skip Routes ( OpenShift native ). It will also install the required dependencies.
    • OpenShift cluster with RHOAI installed: It won't install namespaces, routes, or CRDs. It will install only required depedencies.
      • All the 3 options above are setup related things, after the setup, the test will run. The test code is the same for all the 3 install options above.

Testing instructions

If GHA action passes, all good. No manual testing is required.

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@diegolovison diegolovison marked this pull request as draft September 17, 2024 15:41
@diegolovison diegolovison marked this pull request as ready for review September 17, 2024 16:28
@diegolovison diegolovison changed the title Move kind-integration.sh content to tests.sh Move kind-integration.sh content to tests.sh and target environment for testing Sep 17, 2024
@HumairAK
Copy link
Contributor

/approve

will let @rimolive lgtm it

@HumairAK
Copy link
Contributor

/hold

@rimolive
Copy link
Contributor

/lgtm

…or testing

The goal of test.sh is to be the starting point for allowing a test be running to the following target: kind, fresh OpenShift, an OpenShift cluster with RHOAI installed.
@HumairAK
Copy link
Contributor

/unhold
/lgtm

@rimolive
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented Sep 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK, rimolive

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b616f69 into opendatahub-io:main Sep 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants