Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improved logs for tests #695

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

hbelmiro
Copy link
Contributor

This PR:

  • Adds a log message with the error that occurred when waiting for resources to get ready on functional tests.
  • Changes verifications from assert to require in controllers/testutil/util.go#CompareResources.
2024-08-29T11:35:25-03:00	INFO	Error when trying to get ds-pipeline-ui-testdsp9 (will keep trying until reaching timeout): deployments.apps "ds-pipeline-ui-testdsp9" not found

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Signed-off-by: hbelmiro <helber.belmiro@gmail.com>
@dsp-developers
Copy link
Contributor

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-695
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/695/head
git checkout -b pullrequest 778497c9f816dc4a4a5f79e0ee7e07b96402bcb2
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-695"

More instructions here on how to deploy and test a Data Science Pipelines Application.

@gregsheremeta
Copy link
Contributor

/lgtm

@HumairAK
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented Aug 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 5ba6568 into opendatahub-io:main Aug 29, 2024
6 checks passed
@hbelmiro hbelmiro deleted the improve-logs branch August 29, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants