Clarify the "DSPA not found" log message that happens when a DSPA is deleted #682
Conversation
…deleted Co-authored-by: Greg Sheremeta <gshereme@redhat.com>
|
A new image has been built to help with testing out this PR: To use this image run the following: cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/682/head
git checkout -b pullrequest 8f7fabc640d52318a70e1b49a6e9e72a5533e81c
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-682"More instructions here on how to deploy and test a Data Science Pipelines Application. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HumairAK The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -177,7 +177,8 @@ func (r *DSPAReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl. | |||
| dspa := &dspav1alpha1.DataSciencePipelinesApplication{} | |||
| err := r.Get(ctx, req.NamespacedName, dspa) | |||
| if err != nil && apierrs.IsNotFound(err) { | |||
| log.Info("DSPA resource was not found") | |||
| // TODO change this to a Debug message when doing https://issues.redhat.com/browse/RHOAIENG-1650 | |||
| log.Info("DSPA resource was not found, assuming it was recently deleted, nothing to do here") | |||
There was a problem hiding this comment.
nitpick: small grammar update (line seems like a run-on phrase). would update to something like
DSPA resource was not found - assuming it was recently deleted, nothing to do here
or
DSPA resource was not found, assuming it was recently deleted. Nothing to do here.
The issue resolved by this Pull Request:
n/a
Description of your changes:
Clarify the "DSPA not found" log message that happens when a DSPA is deleted
Testing instructions
n/a
Checklist