Consolidate kustomize binaries in DSPO Makefile #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegolovison
force-pushed
the
kustomize
branch
2 times, most recently
from
963fca0
to
3ad5359
Compare
diegolovison
changed the title
hbelmiro
reviewed
Aug 2, 2024
| else | ||
| KUSTOMIZE_VERSION ?= v3.8.7 | ||
| endif | ||
| KUSTOMIZE_VERSION ?= v5.2.1 |
There was a problem hiding this comment.
Just to confirm, does v5.2.1 work for other architectures, like Macs?
There was a problem hiding this comment.
https://github.com/kubernetes-sigs/kustomize/releases/tag/kustomize%2Fv5.2.1 supports Linux, Window$, and Mac
cc @rimolive
DharmitD
reviewed
Aug 2, 2024
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rimolive The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue resolved by this Pull Request:
Resolves RHOAIENG-10819
Description of your changes:
Replace the
kustomizebinary with$(KUSTOMIZE)Testing instructions
It is automated by
KinD DSPO/DSP Integration Tests / dspo-tests (pull_request)Checklist