Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase default expiry for signed url #676

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

HumairAK
Copy link
Contributor

Increase expiry for signed url to recommended minimum from aws s3

@dsp-developers
Copy link
Contributor

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-676
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/676/head
git checkout -b pullrequest 025289faa4d77863b3ca15be26e85dd0d82faa6c
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-676"

More instructions here on how to deploy and test a Data Science Pipelines Application.

Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@gregsheremeta
Copy link
Contributor

A presigned URL remains valid for the period of time specified when the URL is generated. If you create a presigned URL with the Amazon S3 console, the expiration time can be set between 1 minute and 12 hours.

ref: https://docs.aws.amazon.com/AmazonS3/latest/userguide/using-presigned-url.html

and we've seen it be unreliable below 60 seconds. Suspect on-prem kubernetes node clocks not matching up with AWS clocks or something like that.

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Jul 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gregsheremeta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-676

@HumairAK HumairAK merged commit c03a6ab into opendatahub-io:main Jul 24, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants