Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move embedded binary and bash calls from YAML to a single script #674

Merged
merged 3 commits into from
Jul 19, 2024

Conversation

diegolovison
Copy link
Contributor

@diegolovison diegolovison commented Jul 18, 2024

The issue resolved by this Pull Request:

Resolves RHOAIENG-9518
Create a shared testing artifact for DSPO infrastructure

Description of your changes:

  • Add - '.github/workflows/kind-integration.yml' as part of this PR because changing the yaml must also run the steps
  • All environment variables are defined in the script. The script requires two environment variables GIT_WORKSPACE and REGISTRY_ADDRESS. They can change based on the host. While running in GHA they have a value while running locally they have other value.
  • The job has a lot of steps. The name was translated to a comment. The env were defined early in the script. The working-directory is translated to ( cd ... && ... )
  • We can now use the script locally and on Jenkins

Testing instructions

Have a kind cluster and execute the bash with the two required variables. How to setup the kind cluster you will need to read and understand the yaml|bash scripts.

Checklist

  • [ X ] The commits are squashed in a cohesive manner and have meaningful messages.
  • [ X ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • [ X ] The developer has manually tested the changes and verified that the changes work

@diegolovison diegolovison force-pushed the yaml_to_script branch 2 times, most recently from 1730297 to 2f35d8a Compare July 18, 2024 22:03
@diegolovison diegolovison marked this pull request as ready for review July 18, 2024 22:05
@openshift-ci openshift-ci bot requested review from DharmitD and gmfrasca July 18, 2024 22:05
@diegolovison diegolovison marked this pull request as draft July 18, 2024 22:05
@diegolovison diegolovison force-pushed the yaml_to_script branch 7 times, most recently from b6affff to a2c3c37 Compare July 19, 2024 03:11
Copy link
Member

@gmfrasca gmfrasca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KiND Tests passed and code looks good

/lgtm

@HumairAK
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented Jul 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit dc4aa3a into opendatahub-io:main Jul 19, 2024
5 checks passed
HumairAK pushed a commit to HumairAK/data-science-pipelines-operator that referenced this pull request Jul 19, 2024
Move embedded binary and bash calls from YAML to a single script
HumairAK pushed a commit to HumairAK/data-science-pipelines-operator that referenced this pull request Jul 19, 2024
Move embedded binary and bash calls from YAML to a single script
HumairAK pushed a commit to HumairAK/data-science-pipelines-operator that referenced this pull request Jul 19, 2024
Move embedded binary and bash calls from YAML to a single script
HumairAK pushed a commit to HumairAK/data-science-pipelines-operator that referenced this pull request Jul 19, 2024
Move embedded binary and bash calls from YAML to a single script
HumairAK pushed a commit to HumairAK/data-science-pipelines-operator that referenced this pull request Jul 19, 2024
Move embedded binary and bash calls from YAML to a single script
HumairAK pushed a commit to HumairAK/data-science-pipelines-operator that referenced this pull request Jul 19, 2024
Move embedded binary and bash calls from YAML to a single script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants