-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move embedded binary and bash calls from YAML to a single script #674
Move embedded binary and bash calls from YAML to a single script #674
Conversation
1730297
to
2f35d8a
Compare
b6affff
to
a2c3c37
Compare
a2c3c37
to
e997b15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
KiND Tests passed and code looks good
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HumairAK The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Move embedded binary and bash calls from YAML to a single script
Move embedded binary and bash calls from YAML to a single script
Move embedded binary and bash calls from YAML to a single script
Move embedded binary and bash calls from YAML to a single script
Move embedded binary and bash calls from YAML to a single script
Move embedded binary and bash calls from YAML to a single script
The issue resolved by this Pull Request:
Resolves RHOAIENG-9518
Create a shared testing artifact for DSPO infrastructure
Description of your changes:
- '.github/workflows/kind-integration.yml'
as part of this PR because changing the yaml must also run the stepsGIT_WORKSPACE
andREGISTRY_ADDRESS
. They can change based on the host. While running in GHA they have a value while running locally they have other value.name
was translated to a comment. Theenv
were defined early in the script. Theworking-directory
is translated to ( cd ... && ... )Testing instructions
Have a kind cluster and execute the bash with the two required variables. How to setup the kind cluster you will need to read and understand the yaml|bash scripts.
Checklist