feat: add the ability to configure artifact download link expiry

[HumairAK]

The issue resolved by this Pull Request:

Part of https://issues.redhat.com/browse/RHOAIENG-8225

Depends on: opendatahub-io/data-science-pipelines#62

Description of your changes:

This allows a user to configure the expiry time (in seconds) of an artifact download link via the DSPA. Default is 15 seconds.

Testing instructions

1. Deploy DSPO: Use this one feat: add the ability to configure artifact download link expiry #670
2. Deploy DSPA with .spec.apiServer.artifactSignedURLExpirySeconds set to some value integer.
3. Confirm this value is set in the dsp server deployment as: SIGNED_URL_EXPIRY_TIME_SECONDS

Checklist

• The commits are squashed in a cohesive manner and have meaningful messages.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[dsp-developers]

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-670
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/670/head
git checkout -b pullrequest 8a74a7b680e73bd431f9f18dfe12ae540ab26524
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-670"

More instructions here on how to deploy and test a Data Science Pipelines Application.

[dsp-developers]

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-670

[hbelmiro]

/lgtm

[gmfrasca]

if this is the case, should we make the objStore route enabled by default? (outside scope of this ticket, but if so we should open a ticket to track/follow up on)

[HumairAK]

I don't have a strong opinion on this, this field itself is misplaced (it should be under minio), it only applies to minio which is a dev feature, so I don't think it matters that much.

[gmfrasca]

/approve

but also

/hold

since I believe this needs to go in around the same time as opendatahub-io/data-science-pipelines#62

also giving @HumairAK a chance to see above non-blocking comment, so allowing for a self-unhold

[gregsheremeta]

/hold

need to firm up the API in opendatahub-io/data-science-pipelines#62

(I'm not sure all the references to share_url should remain)

[gregsheremeta]

can you change the commit message and the PR title?

feat: configure artifact download link expiry

(the artifacts aren't expired! just their links ;) )

[dsp-developers]

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-670

[gregsheremeta]

/unhold

[gregsheremeta]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gmfrasca, gregsheremeta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [gmfrasca,gregsheremeta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment