Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled sample pipeline in DSPA samples #668

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

hbelmiro
Copy link
Contributor

@hbelmiro hbelmiro commented Jul 2, 2024

The issue resolved by this Pull Request:

Resolves https://issues.redhat.com/browse/RHOAIENG-6580

Description of your changes:

This PR enables the sample pipeline in DSPA samples.

Testing instructions

Deploy a DSPA sample and the sample pipeline must be present.

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Signed-off-by: hbelmiro <helber.belmiro@gmail.com>
@openshift-ci openshift-ci bot requested review from DharmitD and gmfrasca July 2, 2024 21:28
@dsp-developers
Copy link
Contributor

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-668
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/668/head
git checkout -b pullrequest 89921c5e11c2d1faa22549ac5758e45e88518666
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-668"

More instructions here on how to deploy and test a Data Science Pipelines Application.

Copy link
Member

@gmfrasca gmfrasca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@HumairAK
Copy link
Contributor

HumairAK commented Jul 2, 2024

/approve

Copy link
Contributor

openshift-ci bot commented Jul 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jul 2, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 12c1549 into opendatahub-io:main Jul 2, 2024
6 checks passed
@hbelmiro hbelmiro deleted the RHOAIENG-6580 branch July 3, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants