Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release documentation #666

Merged

Conversation

anishasthana
Copy link
Member

No description provided.

Signed-off-by: Anish Asthana <anishasthana1@gmail.com>
Copy link
Member

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HumairAK could you please take a look and confirm that the GHA being taken out isn't required any more?
Otherwise, changes /lgtm

README.md Outdated
[kubeflow-pipelines-examples]: https://github.com/rh-datascience-and-edge-practice/kubeflow-pipelines-examples
[kubeflow-pipelines-examples]: https://github.com/rh-datascience-and-edge-practice/kubeflow-pipelines-examples

## How to create a DSP release
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is out of scope off a front page release, can we instead keep the original location, but link to that doc instead to increase visibility?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that'd work too. stand by

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@anishasthana anishasthana changed the title Add release action Update release documentation Jun 25, 2024
Signed-off-by: Anish Asthana <anishasthana1@gmail.com>
Signed-off-by: Anish Asthana <anishasthana1@gmail.com>
Signed-off-by: Anish Asthana <anishasthana1@gmail.com>
@HumairAK
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Jun 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 6395b5d into opendatahub-io:main Jun 25, 2024
4 checks passed
@anishasthana anishasthana deleted the add_release_action branch June 25, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants