Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed flaky test IntegrationTestSuite#TestPipelineSuccessfulRun #658

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Fixed flaky test IntegrationTestSuite#TestPipelineSuccessfulRun #658

merged 1 commit into from
Jun 20, 2024

Conversation

hbelmiro
Copy link
Contributor

The issue resolved by this Pull Request:

Resolves https://issues.redhat.com/browse/RHOAIENG-7657

Description of your changes:

This PR improves handling for non-found pipelines and runs.

Testing instructions

KinD DSPO/DSP Integration Tests must always pass.

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@hbelmiro hbelmiro marked this pull request as draft June 13, 2024 13:44
@hbelmiro hbelmiro changed the title Fixed flaky test IntegrationTestSuite#TestPipelineSuccessfulRun WIP - Fixed flaky test IntegrationTestSuite#TestPipelineSuccessfulRun Jun 13, 2024
@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-658

9 similar comments
@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-658

@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-658

@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-658

@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-658

@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-658

@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-658

@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-658

@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-658

@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-658

@hbelmiro hbelmiro force-pushed the RHOAIENG-7657 branch 4 times, most recently from 58a0e48 to 93b641f Compare June 18, 2024 13:35
@hbelmiro
Fixed flaky test IntegrationTestSuite#TestPipelineSuccessfulRun
5fe2b21 
Signed-off-by: hbelmiro <helber.belmiro@gmail.com>
@hbelmiro hbelmiro changed the title WIP - Fixed flaky test IntegrationTestSuite#TestPipelineSuccessfulRun Fixed flaky test IntegrationTestSuite#TestPipelineSuccessfulRun Jun 18, 2024
@hbelmiro hbelmiro marked this pull request as ready for review June 18, 2024 13:51
@openshift-ci openshift-ci bot requested a review from DharmitD June 18, 2024 13:51
@gregsheremeta
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 18, 2024
DharmitD
DharmitD reviewed Jun 18, 2024
View reviewed changes
Copy link
Member

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the DSPO integration CI run, made sure it works as expected.

/lgtm

@VaniHaripriya
Copy link
Contributor

Thank you for working on this !
/lgtm

@HumairAK
Copy link
Contributor

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit c9eefa6 into opendatahub-io:main Jun 20, 2024
5 checks passed
@hbelmiro hbelmiro deleted the RHOAIENG-7657 branch June 20, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DharmitD DharmitD DharmitD left review comments

@amadhusu amadhusu Awaiting requested review from amadhusu

@gregsheremeta gregsheremeta Awaiting requested review from gregsheremeta

Assignees

@gregsheremeta gregsheremeta

@DharmitD DharmitD

@VaniHaripriya VaniHaripriya

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hbelmiro @dsp-developers @gregsheremeta @VaniHaripriya @HumairAK @DharmitD