Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable gke metadata in kfp ui #657

Merged

Conversation

HumairAK
Copy link
Contributor

@HumairAK HumairAK commented Jun 7, 2024

this disables the gke ui bits from loading in the kfp ui

@HumairAK HumairAK requested review from rimolive and removed request for gregsheremeta and hbelmiro June 7, 2024 13:59
@dsp-developers
Copy link
Contributor

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-657
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/657/head
git checkout -b pullrequest d19a51128218a586d14494b5d5f69778ee10730a
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-657"

More instructions here on how to deploy and test a Data Science Pipelines Application.

@rimolive
Copy link
Contributor

rimolive commented Jun 7, 2024

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Jun 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rimolive

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 7, 2024
@rimolive
Copy link
Contributor

rimolive commented Jun 7, 2024

/hold

Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@openshift-ci openshift-ci bot removed the lgtm label Jun 7, 2024
@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-657

@rimolive
Copy link
Contributor

rimolive commented Jun 7, 2024

/unhold

@rimolive
Copy link
Contributor

rimolive commented Jun 7, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 7, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 383a123 into opendatahub-io:main Jun 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants