-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated metadata envoy route name #650
Updated metadata envoy route name #650
Conversation
A new image has been built to help with testing out this PR: To use this image run the following: cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/650/head
git checkout -b pullrequest dbfedb6ffec8f69df29d946a63c82d6681c3e2e3
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-650" More instructions here on how to deploy and test a Data Science Pipelines Application. |
Update metadata envoy service name
ae6616d
to
f1ea7b6
Compare
Change to PR detected. A new PR build was completed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Tested with project test-jgarciao-dspv2-123456789012
.
oc get routes
NAME HOST/PORT PATH SERVICES PORT TERMINATION WILDCARD
ds-pipeline-md-sample ds-pipeline-md-sample-test-jgarciao-dspv2-123456789012.apps.hbelmiro-10.dev.datahub.redhat.com ds-pipeline-metadata-envoy-sample oauth2-proxy reencrypt/Redirect None
ds-pipeline-sample ds-pipeline-sample-test-jgarciao-dspv2-123456789012.apps.hbelmiro-10.dev.datahub.redhat.com ds-pipeline-sample oauth reencrypt/Redirect None
ds-pipeline-ui-sample ds-pipeline-ui-sample-test-jgarciao-dspv2-123456789012.apps.hbelmiro-10.dev.datahub.redhat.com ds-pipeline-ui-sample 8443 reencrypt/Redirect None
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/Approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DharmitD The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The issue resolved by this Pull Request:
Resolves RHOAIENG-5348
Description of your changes:
Testing instructions
Deploy DSPO and create a DSPA instance. The metadata envoy route should be as shown in the below format-
https://ds-pipeline-md-myproject.apps.clustername.domain.com/
Checklist