Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated metadata envoy route name #650

Merged

Conversation

VaniHaripriya
Copy link
Contributor

The issue resolved by this Pull Request:

Resolves RHOAIENG-5348

Description of your changes:

  1. Updated the metadata envoy route name to avoid the issue with creation of pipeline server when the project name is longer than 31 chars.
  2. This is the route name before the change - https://ds-pipeline-metadata-envoy-dspa-MYPROJECT.apps.clustername.domain.com/ , when the project name is longer than 31 chars pipeline server fails to create. Updated the route to this format - https://ds-pipeline-md-myproject.apps.clustername.domain.com/ which allows the project name to have more chars.

Testing instructions

Deploy DSPO and create a DSPA instance. The metadata envoy route should be as shown in the below format-
https://ds-pipeline-md-myproject.apps.clustername.domain.com/

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from amadhusu and HumairAK May 14, 2024 13:56
@dsp-developers
Copy link
Contributor

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-650
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/650/head
git checkout -b pullrequest dbfedb6ffec8f69df29d946a63c82d6681c3e2e3
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-650"

More instructions here on how to deploy and test a Data Science Pipelines Application.

Update metadata envoy service name
@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-650

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Tested with project test-jgarciao-dspv2-123456789012.

oc get routes                                  
NAME                    HOST/PORT                                                                                        PATH   SERVICES                            PORT           TERMINATION          WILDCARD
ds-pipeline-md-sample   ds-pipeline-md-sample-test-jgarciao-dspv2-123456789012.apps.hbelmiro-10.dev.datahub.redhat.com          ds-pipeline-metadata-envoy-sample   oauth2-proxy   reencrypt/Redirect   None
ds-pipeline-sample      ds-pipeline-sample-test-jgarciao-dspv2-123456789012.apps.hbelmiro-10.dev.datahub.redhat.com             ds-pipeline-sample                  oauth          reencrypt/Redirect   None
ds-pipeline-ui-sample   ds-pipeline-ui-sample-test-jgarciao-dspv2-123456789012.apps.hbelmiro-10.dev.datahub.redhat.com          ds-pipeline-ui-sample               8443           reencrypt/Redirect   None

Copy link
Member

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/Approve

Copy link
Contributor

openshift-ci bot commented May 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DharmitD

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 2daad7a into opendatahub-io:main May 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants