Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ConfigMap and Secret paths for TLS enabled DB/Storage #640

Merged

Conversation

DharmitD
Copy link
Member

@DharmitD DharmitD commented May 8, 2024

The issue resolved by this Pull Request:

Resolves https://issues.redhat.com/browse/RHOAIENG-4254

Description of your changes:

Follow up to #635

Created the following directory instead in tests folder in the root of the repo :

├── resources
│   ├── external-pre-reqs
│   │   ├── kustomization.yaml
│   │   ├── mariadb-secret.yaml               
│   │   ├── minio-secret.yaml
│   │   └── root-ca.yaml
  • mariadb-secret.yaml has the same contents as this
  • minio-secret.yaml has the same contents as this

Removed this. And deployed them all together via kustomize build instead.

Testing instructions

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@DharmitD DharmitD force-pushed the external-tls-refactor branch 5 times, most recently from 11ffe46 to be3cf4c Compare May 9, 2024 00:19
@DharmitD DharmitD force-pushed the external-tls-refactor branch 2 times, most recently from 6573473 to b810e57 Compare May 9, 2024 15:36
@HumairAK
Copy link
Contributor

HumairAK commented May 9, 2024

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented May 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label May 9, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit c55325e into opendatahub-io:main May 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants