Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CustomConfig to WorkflowController #636

Merged
merged 1 commit into from
May 6, 2024

Conversation

hbelmiro
Copy link
Contributor

The issue resolved by this Pull Request:

Resolves https://issues.redhat.com/browse/RHOAIENG-5287

Description of your changes:

Added CustomConfig to WorkflowController.

Testing instructions

Deploy config/samples/v2/custom-workflow-controller-config and run a pipeline. The pipeline must complete successfully.

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@dsp-developers
Copy link
Contributor

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-636
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/636/head
git checkout -b pullrequest 3d9bf9cd5b61bde8fde0b526fcc78432da73976c
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-636"

More instructions here on how to deploy and test a Data Science Pipelines Application.

Signed-off-by: hbelmiro <helber.belmiro@gmail.com>
@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-636

@hbelmiro hbelmiro marked this pull request as ready for review April 29, 2024 17:58
@VaniHaripriya
Copy link
Contributor

/lgtm
Deployed config/samples/v2/custom-workflow-controller-config and created a pipeline run. The pipeline completed successfully.

@HumairAK
Copy link
Contributor

HumairAK commented May 6, 2024

/approve

@HumairAK HumairAK merged commit 575c774 into opendatahub-io:main May 6, 2024
5 of 6 checks passed
Copy link
Contributor

openshift-ci bot commented May 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label May 6, 2024
@hbelmiro hbelmiro deleted the RHOAIENG-5287 branch May 6, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants