Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-1687- Add DSPO CI tests against custom pip server behind a self-signed cert #634

Merged

Conversation

VaniHaripriya
Copy link
Contributor

@VaniHaripriya VaniHaripriya commented Apr 24, 2024

The issue resolved by this Pull Request:

Resolves RHOAIENG-1687

Description of your changes:

  1. Added Pypi server and nginx resources to github resources to deploy custom pip server behind a self-signed cert using nginx reverse proxy.
  2. Added new github action to Kind-integration.yaml to deploy custom pip server.
  3. Added a new pipeline with PIP_INDEX_URL as the custom pip server.
  4. Uploaded the new pipeline and created another test to verify the completion of the pipeline run.

Testing instructions

Please follow the instructions from here to run the integration tests in local. It can also be verified by looking at the "KinD DSPO/DSP Integration Tests" workflow run in this PR.

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nitpicks.

tests/pipeline_test.go Outdated Show resolved Hide resolved
.github/resources/pypiserver/generate-deploy-certs.sh Outdated Show resolved Hide resolved
tests/resources/test-pipeline-with-custom-pip-server.py Outdated Show resolved Hide resolved
@VaniHaripriya VaniHaripriya force-pushed the RHOAIENG-1687-New branch 5 times, most recently from 018fae4 to 38bb4c7 Compare May 23, 2024 19:59
.github/resources/pypiserver/base/pvc.yaml Outdated Show resolved Hide resolved
.github/resources/pypiserver/base/pypiserver.yaml Outdated Show resolved Hide resolved
.github/resources/pypiserver/base/pypiserver.yaml Outdated Show resolved Hide resolved
.github/workflows/kind-integration.yml Outdated Show resolved Hide resolved
.github/resources/pypiserver/package_upload.sh Outdated Show resolved Hide resolved
tests/pipeline_test.go Show resolved Hide resolved
@HumairAK
Copy link
Contributor

HumairAK commented Jun 5, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Jun 5, 2024
Copy link
Contributor

openshift-ci bot commented Jun 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 5, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 2094b96 into opendatahub-io:main Jun 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants