Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-1669 - Modified the Request Size for Manager #633

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

amadhusu
Copy link
Contributor

@amadhusu amadhusu commented Apr 24, 2024

The issue resolved by this Pull Request:

Resolves RHOAIENG-1669

Description of your changes:

Leveraging Vertical Pod Autoscaling recommender , I got values suggested for the request size to be a bit more when I had a single DSPA deployed along with DSPO.
I took the safe route of taking the minimum suggested values to modify the request size for manager by the Jira Reporter instead as it is recommended to leverage Vertical Pod Autoscaling for atleast a week before considering the suggested values.

Testing instructions

  1. Deploy DSPO
  2. Deploy DSPA and see if the sample pipeline works as it should.

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Signed-off-by: Achyut Madhusudan <amadhusu@redhat.com>
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified DSPO comes up by checking CI logs.

/lgtm

@HumairAK
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Apr 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit e914f1d into opendatahub-io:main Apr 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants