RHOAIENG-5243 - Added overlays for deploying dspo and argo separately

[amadhusu]

The issue resolved by this Pull Request:

Resolves RHOAIENG-5243

Description of your changes:

Added overlays for deploying dspo and argo separately

Testing instructions

Normal Sanity checks to see if everything is working as it should.

Checklist

• The commits are squashed in a cohesive manner and have meaningful messages.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[dsp-developers]

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-626
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/626/head
git checkout -b pullrequest eae9ef2b80f37c91a33301c953a0c1b7746fbbab
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-626"

More instructions here on how to deploy and test a Data Science Pipelines Application.

[HumairAK]

@VaishnaviHire or @zdtsw

wdyt about splitting up the overlays in this way, so odh operator can introduce an option to deploy with or without argo by pointing at one, or both nested overlays

[zdtsw]

food for thought: what i can see the difference for "odh" and "rhoai" is only the namespace "opendatahub" vs "redhat-ods-applications"?
then why not to only keep one but set a configmap to get the proper namespace?
say in params.env you can have a
namespace=opendatahub when deploy to rhoai by RHOAI operator, we will replace this to namespace=redhat-ods-applicatons
all you need is to add this into configMapGenerator, looking for data.namespace, e.g

vars:
- name: namespace
  objref:
    kind: ConfigMap
    name: dsp-config
    apiVersion: v1
  fieldref:
    fieldpath: data.namespace

[zdtsw]

@VaishnaviHire or @zdtsw

wdyt about splitting up the overlays in this way, so odh operator can introduce an option to deploy with or without argo by pointing at one, or both nested overlays

yeah, this is one of the things i was considering weeks ago.
odh operator only need to check if "some condition is matched, i.e Argo CRD in cluster" we can deploy "argo" or fall back to the "tekton" one.

[dsp-developers]

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-626

[HumairAK]

food for thought: what i can see the difference for "odh" and "rhoai" is only the namespace "opendatahub" vs "redhat-ods-applications"?
then why not to only keep one but set a configmap to get the proper namespace?
say in params.env you can have a

@zdtsw , the intended purpose of this design is to allow us to easily patch rhoai/odh specific changes as needed, without affecting the other platform

Furthermore, we are currently reconsidering in slack whether we want to make it possible for the user to deploy their own argo at all (i.e. we always try to deploy argo), regardless I think we should still go through this change even if we have a no-op from rhoai/odh operator side, to offer flexibility in the future should we change our minds. Also it can be good to have for dev testing.

/lgtm
/approve

[HumairAK]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [HumairAK]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment