Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated description in datasciencepipelinesapplications.opendatahub.io_datasciencepipelinesapplications.yaml #625

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

hbelmiro
Copy link
Contributor

Description of your changes:

This PR fixes a description that is automatically generated. This probably was caused by a missing file in a previous commit.

Testing instructions

How to reproduce

  1. Checkout the main branch.
  2. Run make functest
  3. Run git status and you'll see this update.

How to test

  1. Checkout this branch
  2. Run make functest
  3. Run git status. No changes must be shown.

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

…o_datasciencepipelinesapplications.yaml

Signed-off-by: hbelmiro <helber.belmiro@gmail.com>
@dsp-developers
Copy link
Contributor

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-625
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/625/head
git checkout -b pullrequest 4330cd76b8a337f67caf0dcea11c60d1cefda227
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-625"

More instructions here on how to deploy and test a Data Science Pipelines Application.

Copy link
Contributor

@amadhusu amadhusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, yep we should check for these cases where make generate was missed by a previous change to the file api/v1alpha1/dspipeline_types.go

@HumairAK
Copy link
Contributor

/lgtm
/approve

Copy link
Member

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/Approve

Copy link
Contributor

openshift-ci bot commented Apr 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amadhusu, DharmitD, HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 139943a into opendatahub-io:main Apr 16, 2024
6 checks passed
@hbelmiro hbelmiro deleted the fix-crd branch April 16, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants