-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated handling of dspa tls config #620
Conversation
A new image has been built to help with testing out this PR: To use this image run the following: cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/620/head
git checkout -b pullrequest a35f4452b3368b3ceb1a88270fc6c6cdabc4ed20
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-620" More instructions here on how to deploy and test a Data Science Pipelines Application. |
68f45d5
to
9b82bb4
Compare
Change to PR detected. A new PR build was completed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to verify the first test case but the second test case with the provided yaml is failing as I believe there are more steps required which isn't mentioned in the Testing steps. I believe the pre-requisite for the second test case would be to have this said externaldb already present in the cluster maybe?
@amadhusu Thank you for testing. I updated the testing instructions to deploy an external DB for the second test. |
78a8eee
to
2fe1ae6
Compare
Change to PR detected. A new PR build was completed. |
b1d6be2
to
97d1708
Compare
Change to PR detected. A new PR build was completed. |
Add space Created new func for default DBExtraParams Remove unused func Updated DBExtraParams
3428695
to
2fbdbf1
Compare
Change to PR detected. A new PR build was completed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving after all the requested changes.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amadhusu, HumairAK The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The issue resolved by this Pull Request:
Resolves RHOAIENG-4384
Description of your changes:
Removed the string template for default value of DbExtraParams and created a struct to handle the tls config.
Testing instructions
Checklist