-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding exclusive notebook pod label #619
Adding exclusive notebook pod label #619
Conversation
A new image has been built to help with testing out this PR: To use this image run the following: cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/619/head
git checkout -b pullrequest c3902a89d119a5e67f685f27738dd94cafe67aaa
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-619" More instructions here on how to deploy and test a Data Science Pipelines Application. |
Normally I'd say we should have a deprecation period, and think through the timing of this ... but it's unlikely that anyone is actually relying on this today. So I think it should be as easy as what you've got here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
thanks, providing my review based on the label
that would be present in workbenches that would be in 2.11 ODH or above.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HumairAK The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The issue resolved by this Pull Request:
Resolves https://issues.redhat.com/browse/RHOAIENG-4546
Description of your changes:
Replace the existing generic dashboard label in the network policy's pod selector with the new exclusive static notebook pod label.
Testing instructions
Deploy DSPO + DSPA.
Deploy ODH Dashboard and Workbenches in the same namespace as that of the DSPA instance.
From the notebook pod, try this curl command:
curl http://<data-science-pipelines-service-hostname>:8888/apis/v1beta1/runs
This command should return a JSON response with details about the existing pipeline runs. If no runs exist, you'll still see the structure of the response, confirming that the API endpoint is accessible and functioning.
Checklist