Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding exclusive notebook pod label #619

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

DharmitD
Copy link
Member

@DharmitD DharmitD commented Mar 27, 2024

The issue resolved by this Pull Request:

Resolves https://issues.redhat.com/browse/RHOAIENG-4546

Description of your changes:

Replace the existing generic dashboard label in the network policy's pod selector with the new exclusive static notebook pod label.

Testing instructions

Deploy DSPO + DSPA.
Deploy ODH Dashboard and Workbenches in the same namespace as that of the DSPA instance.
From the notebook pod, try this curl command:
curl http://<data-science-pipelines-service-hostname>:8888/apis/v1beta1/runs
This command should return a JSON response with details about the existing pipeline runs. If no runs exist, you'll still see the structure of the response, confirming that the API endpoint is accessible and functioning.

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@dsp-developers
Copy link
Contributor

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-619
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/619/head
git checkout -b pullrequest c3902a89d119a5e67f685f27738dd94cafe67aaa
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-619"

More instructions here on how to deploy and test a Data Science Pipelines Application.

@gregsheremeta
Copy link
Contributor

Normally I'd say we should have a deprecation period, and think through the timing of this ... but it's unlikely that anyone is actually relying on this today. So I think it should be as easy as what you've got here.

@DharmitD DharmitD marked this pull request as ready for review March 28, 2024 20:59
@openshift-ci openshift-ci bot requested a review from amadhusu March 28, 2024 20:59
@DharmitD DharmitD changed the title WIP: Adding exclusive notebook pod label Adding exclusive notebook pod label Mar 28, 2024
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thanks, providing my review based on the label
that would be present in workbenches that would be in 2.11 ODH or above.

@HumairAK
Copy link
Contributor

HumairAK commented Apr 5, 2024

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Apr 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Apr 5, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit c103f8f into opendatahub-io:main Apr 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants