Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary DSPO parameters #618

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

rimolive
Copy link
Contributor

@rimolive rimolive commented Mar 26, 2024

The issue resolved by this Pull Request:

Resolves RHOAIENG-4256

Description of your changes:

Removes parameters that aren't used/duplicated by the DSPO.

Testing instructions

Just build the DSPO image and deploy it with a valid DSPA object.

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@dsp-developers
Copy link
Contributor

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-618
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/618/head
git checkout -b pullrequest 76ce5259598750093ec31a4d35b0ac252fbfcca5
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-618"

More instructions here on how to deploy and test a Data Science Pipelines Application.

@HumairAK
Copy link
Contributor

tested with kustomize build:

$ cat apps_v1_deployment_data-science-pipelines-operator-controller-manager.yaml | yq .spec.template.spec.containers[0].env[-1]
name: DSPO_REQUEUE_TIME
value: 20s

and no usage of mlmd writer image found, lgtm

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Mar 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 4dda89c into opendatahub-io:main Mar 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants