Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up unused artifacts, add deprecated notices. #610

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

HumairAK
Copy link
Contributor

@HumairAK HumairAK commented Mar 18, 2024

  1. Remove crd viewer
  2. Add deprecated warnings for v1 specific fields in dspa
  3. Ignore linting on dspa_params.go, so ci does not fail when it sees statticheck deprecated errors
  4. Update dspa_all_fields.yaml to reflect latest state of possible dspa configuration options

Testing instructions:

  1. Deploy DSPO
  2. Navigate to OCP API Explorer >DataSciencePipelinesApplication > create
  3. enter deprecated fields, mouse over, make sure they list the notices, example:

image

@dsp-developers
Copy link
Contributor

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-610
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/610/head
git checkout -b pullrequest 69fd88e012a02077bcb3a9e4d76ffc65dbe76d80
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-610"

More instructions here on how to deploy and test a Data Science Pipelines Application.

api/v1alpha1/dspipeline_types.go Show resolved Hide resolved
// Default: true
// Deprecated: v1 only, will be removed in the future.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, should we be bumping our API to v2alpha1 for DSP v2?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, depending on the answer to the above, we may want to say "v1alpha1" here. I think you mean "DSP v1" when you say "v1", but in this CRD API file, "v1" means a kubernetes API and not a version of the project. It could cause confusion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, should we be bumping our API to v2alpha1 for DSP v2?

This is something we should have probably considered way ahead of time. I think crd version conversion strategy is upto us to decide when we do it. I'm not sure what the standard practice is here, but I don't think we should update the version of the crd this close to release, it would be difficult to account for all edge cases we need to handle.

I updated v1 to say "DSP V1" however.

@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-610

@gregsheremeta
Copy link
Contributor

/lgtm

Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-610

Copy link
Member

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm, and since the CI checks also pass

/Approve

Copy link
Contributor

openshift-ci bot commented Mar 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DharmitD

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 99e01be into opendatahub-io:main Mar 20, 2024
6 checks passed
@gregsheremeta
Copy link
Contributor

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants