feat: always enable server config and make it customizable

[HumairAK]

Description of your changes:

We should always mount the server config, regadless of whether we have a custom cabundle or not, so that we don't end up in a situation where based on the cabundle we are using different configs, as that may result in different behaviors if somehow the default config in the dsp server image ends up diverging from the one we mount.

To prevent future issues with server config, this pr also adds the ability for users to provide a custom sever config, in case the default options are not sufficient, the user can customize their own server config in such a case, for instance changing the path in s3 where pipelines are stored.

The name for the default server config is also renamed to be consistent with the rest of the dspa's resource naming pattern "ds-pipelines-*"

Testing instructions

1. Deploy simple dspa
2. confirm server-config is mounted, in the pipeline server pod you should see the following:

         volumeMounts:
            - name: server-config
              mountPath: /config/config.json
              subPath: config.json

3. confirm pipeline runs successfully
4. In a separate namespace, deploy another dspa but with a custom server config, for example:

kind: ConfigMap
apiVersion: v1
metadata:
  name: custom-script
  namespace: dspa1
  labels:
    app: ds-pipeline-test
    component: data-science-pipelines
data:
  blah: |
    {
      "DBConfig": {
        "MySQLConfig": {
          "ExtraParams": {"tls":"false"},
          "GroupConcatMaxLen": "4194304"
         },
        "PostgreSQLConfig": {},
        "ConMaxLifeTime": "120s"
      },
      "DBDriverName": "mysql",
      "InitConnectionTimeout": "6m",
      "CacheEnabled": "false"
    }

and in dspa:

apiVersion: datasciencepipelinesapplications.opendatahub.io/v1alpha1
kind: DataSciencePipelinesApplication
metadata:
  name: test
spec:
  apiServer:
    customServerConfigMap:
      name: custom-script
      key: blah
  dspVersion: v2
  objectStorage:

    minio:
      deploy: true
      image: 'quay.io/opendatahub/minio:RELEASE.2019-08-14T20-37-41Z-license-compliance'
  mlpipelineUI:
    image: quay.io/opendatahub/ds-pipelines-frontend:latest

then inspect the apiserver mounts:

 volumeMounts:
    - name: server-config
      mountPath: /config/config.json
      subPath: blah

Checklist

• The commits are squashed in a cohesive manner and have meaningful messages.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[dsp-developers]

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-605
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/605/head
git checkout -b pullrequest a3ceacb47f3fd4c0bb0d5f9acdf49b904394a39b
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-605"

More instructions here on how to deploy and test a Data Science Pipelines Application.

[dsp-developers]

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-605

[dsp-developers]

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-605

[dsp-developers]

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-605

[amadhusu]

Worked as suggested with the default server config and customized one as well. Pipelines ran successfully as well.

default server config

custom server config

[rimolive]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amadhusu, rimolive

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rimolive]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment