feat: add rhoai overlay.

[HumairAK]

The issue resolved by this Pull Request:

Related: https://issues.redhat.com/browse/RHOAIENG-2877

Description of your changes:

Provide a rhoai overlay alongside an odh overlay
This will allow us to patch any rhoai specific changes in the future
Also add argo server image to params.env so odh operator can sub this in for downstream.

One change here to watch out is the change to the configmapGenerator suffix, this makes it so that the 2 configmaps created for the DSPO deployment no longer have the hash suffix.

Testing instructions

• confirm kustomize builds in the overlay directories build as expected, and that argo image is subbed in
• make deployODH behavior should not have changed other than the configmap name change, the output should be otherwise the same
• currently the rhoai overlay should function identically to the odh overlay

Checklist

• The commits are squashed in a cohesive manner and have meaningful messages.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[dsp-developers]

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-572
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/572/head
git checkout -b pullrequest ef760ea0e1c3f4bb2f912df0dec64fcbc36b527b
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-572"

More instructions here on how to deploy and test a Data Science Pipelines Application.

[dsp-developers]

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-572

[dsp-developers]

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-572

[dsp-developers]

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-572

[gregsheremeta]

I've forgotten what little I used to know about kustomize, so I'm not a great help with reviewing the logic.

Was there any angst about adding an "rhoai" directory in this ODH repo? Have we done that in other places?

[dsp-developers]

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-572

[HumairAK]

Was there any angst about adding an "rhoai" directory in this ODH repo? Have we done that in other places?

I don't see why there would be, the point of overlays is to configure your common yamls for different environments/platforms/use cases etc.

The existence of this folder actually helps to make sure we only confine any rhoai specific manifests in this overlay, while keeping our generic templates distro agnostic

[DharmitD]

Will let Greg review the changes he requested, but otherwise
/lgtm

[gregsheremeta]

/lgtm

[gregsheremeta]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gregsheremeta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [gregsheremeta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment